test(spanner): unflake StreamingRetryBudgetMockServerTest totalTimeoutExhausted tests - #14475
Merged
sakthivelmanii merged 1 commit intoSep 22, 2026
Merged
Conversation
…tExhausted tests When retrying with a total timeout, GAX clamps the RPC timeout of the final attempt to the remaining time. Under thread scheduling contention, this can cause the final attempt to time out with DEADLINE_EXCEEDED instead of returning the mock server's error code. Update totalTimeoutExhausted_* tests to accept either the expected error code or DEADLINE_EXCEEDED upon total timeout exhaustion.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the assertions in StreamingRetryBudgetMockServerTest.java to accept DEADLINE_EXCEEDED in addition to UNAVAILABLE or RESOURCE_EXHAUSTED when a total timeout is exhausted. This accommodates GAX's behavior of truncating the per-attempt RPC timeout to the remaining total timeout, which can lead to a deadline expiration on the final attempt. I have no feedback to provide as there are no review comments.
sakthivelmanii
enabled auto-merge (squash)
September 22, 2026 12:20
rahul2393
approved these changes
Sep 22, 2026
sakthivelmanii
deleted the
unflake-streaming-retry-budget-mock-server-test
branch
September 22, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When retrying with a total timeout, GAX clamps the RPC timeout of the final attempt to the remaining time. Under thread scheduling contention, this can cause the final attempt to time out with DEADLINE_EXCEEDED instead of returning the mock server's error code.
Update totalTimeoutExhausted_* tests to accept either the expected error code or DEADLINE_EXCEEDED upon total timeout exhaustion.