Conversation
…ames The `java-shopping-merchant-issue-resolution` and `java-shopping-merchant-order-tracking` modules were generated into directories with a duplicated prefix: `java-java-shopping-merchant-*`. Every other module in the monorepo follows the `java-<service>` convention. Changes: - Rename both directories to drop the extra `java-` prefix. - Update the `<module>` entries in the root `pom.xml`, moving them into their correct alphabetical position alongside the other `java-shopping-merchant-*` modules. - Fix the GitHub links for both libraries in the root `README.md`. - Fix `repo_short` in each module's `.repo-metadata.json`. No Maven coordinates change, so this has no effect on published artifacts.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a naming typo in the repository paths and metadata for the Merchant Issue Resolution API and Merchant Order Tracking API, changing the incorrect "java-java-" prefix to "java-" in the README.md and .repo-metadata.json files. I have no additional feedback to provide as the changes are straightforward and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two modules were generated into directories with a duplicated
java-prefix:java-java-shopping-merchant-issue-resolutionjava-java-shopping-merchant-order-trackingEvery other module in this monorepo follows the
java-<service>convention, and all their sibling Merchant API libraries are namedjava-shopping-merchant-*(accounts, conversions, datasources, inventories, lfp, ...).Changes
java-prefix (done withgit mv, so history is preserved and the diff registers as pure renames).<module>entries in the rootpom.xml. They had been sorted underjava-j*(stranded betweenjava-iotandjava-kms) and are now moved into their correct alphabetical position alongside the otherjava-shopping-merchant-*modules.tree/main/...links for both libraries in the rootREADME.md, which currently 404.repo_shortin each module's.repo-metadata.json.Impact
None on published artifacts. Maven coordinates are unchanged — both libraries already publish correctly as
com.google.shopping:google-shopping-merchant-issue-resolutionandcom.google.shopping:google-shopping-merchant-order-tracking. This only corrects directory naming and the stale links/metadata that referenced it.