chore(gax): deprecate ApiTracer.inScope() - #14467
jinseopkim0 wants to merge 2 commits into
Conversation
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the inScope() method across ApiTracer, BaseApiTracer, and CompositeTracer by adding @Deprecated and @ObsoleteApi annotations. The feedback suggests making the deprecation message in @ObsoleteApi more generic by removing the specific reference to 'OpenTelemetry tracer implementations' to avoid referencing specific or potentially stale implementations in the future.
|
@gemini-code-assist review |
1 similar comment
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request deprecates the inScope() method across ApiTracer, BaseApiTracer, and CompositeTracer by adding @Deprecated and @ObsoleteApi annotations. However, the required import com.google.api.core.ObsoleteApi is missing in both ApiTracer.java and BaseApiTracer.java, which will lead to compilation failures.
There was a problem hiding this comment.
Code Review
This pull request deprecates the inScope() method across ApiTracer, BaseApiTracer, and CompositeTracer by adding the @Deprecated and @ObsoleteApi annotations, indicating that scope management is now handled internally. There are no review comments to address, and I have no additional feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request deprecates the inScope() method across ApiTracer, BaseApiTracer, and CompositeTracer using the @Deprecated and @ObsoleteApi annotations. The feedback identifies critical compilation errors in ApiTracer.java and BaseApiTracer.java because the com.google.api.core.ObsoleteApi class is used without being imported.
| * @deprecated Scope management is handled internally. | ||
| */ | ||
| @Deprecated | ||
| @ObsoleteApi("Scope management is handled internally") |
There was a problem hiding this comment.
The annotation @ObsoleteApi is used here, but com.google.api.core.ObsoleteApi is not imported in this file. This will cause a compilation error. Please add import com.google.api.core.ObsoleteApi; to the imports section of this file.
|
|
||
| @Override | ||
| @Deprecated | ||
| @ObsoleteApi("Scope management is handled internally") |
There was a problem hiding this comment.
The annotation @ObsoleteApi is used here, but com.google.api.core.ObsoleteApi is not imported in this file. This will cause a compilation error. Please add import com.google.api.core.ObsoleteApi; to the imports section of this file.
|
|
1 participant
This PR deprecates
ApiTracer.inScope()with@Deprecatedand@ObsoleteApi, as span scope lifecycle is now managed internally by tracer implementations rather than requiring callers to manually install thread locals.