Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test, partialOmissionMultiEntryTest, to verify how MutateRowsAttemptCallable handles missing entry responses in a multi-entry request. The feedback suggests replacing the manual try-catch block of Throwable with assertThrows to improve test robustness and follow idiomatic testing practices.
Address review comment by replacing the manual try-catch block with JUnit assertThrows(ExecutionException.class, ...).
The topLevelStatus variable in the MutateRowsException handler had incorrect 2-space continuation indentation; reformatted to 4-space per google-java-format as flagged by the Librarian CI check. Change-Id: I66b9be44c220581c16cc465a331d6fb1a0e2daba
mutianf
force-pushed
the
fix-mutaterows-pitfall-5-6
branch
from
September 21, 2026 18:36
6b64115 to
f2d5417
Compare
mutianf
enabled auto-merge (squash)
September 21, 2026 18:38
mutianf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RowsResponse