Skip to content

feat: log actionable errors on operation failure in LoggingTracer - #14460

Draft
jinseopkim0 wants to merge 1 commit into
mainfrom
feat-t3-logging-spans
Draft

jinseopkim0 wants to merge 1 commit into
mainfrom
feat-t3-logging-spans

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Implement operationFailed in LoggingTracer to log actionable errors for logical operation failures.

Fixes b/564459813

@jinseopkim0

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the operationFailed method in LoggingTracer to record actionable errors when an operation fails, and adds a corresponding unit test testOperationFailed_LogsError in LoggingTracerTest to verify its logging behavior. I have no feedback to provide as there are no review comments.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the operationFailed method in LoggingTracer to record actionable errors, and adds a corresponding unit test testOperationFailed_LogsError in LoggingTracerTest to verify its logging behavior. There are no review comments, and I have no feedback to provide.

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant