Conversation
…s when service account impersonation is configured
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates AwsCredentials to reuse cached impersonated credentials during access token refreshes, preventing redundant AWS metadata queries when the source STS token is still valid. The test suite has been updated to assert correct request counts and verify caching behavior. A review comment suggests simplifying the implementation in AwsCredentials by delegating directly to super.refreshAccessToken() instead of duplicating the lazy initialization and delegation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When service account impersonation is configured on
AwsCredentials,refreshAccessToken()previously calledretrieveSubjectToken()on the outer credential beforeexchangeExternalCredentialForAccessToken()delegated toimpersonatedCredentials.refreshAccessToken(). This queried the AWS metadata server orAwsSecurityCredentialsSuppliertwice and discarded the first signedGetCallerIdentitysubject token.AwsCredentials.refreshAccessToken()now checksgetServiceAccountImpersonationUrl() != nulland delegates directly tothis.impersonatedCredentials.refreshAccessToken(), reusing the cachedimpersonatedCredentialsinstance across refreshes.Testing
AwsCredentialsTestandExternalAccountCredentialsTest(91 tests passing)byoid-testIAM role in AWS account077071391996,us-east-2) againstbyoid-pool/providers/aws-pid2onsts.googleapis.com,iamcredentials.googleapis.com,oauth2.googleapis.com/tokeninfo, andpubsub.googleapis.com: https://paste.googleplex.com/4757180109160448