Skip to content

feat(storage): add bucket IP filtering samples and tests - #14328

Open
nidhiii-27 wants to merge 4 commits into
mainfrom
samples-bucket-ip-filter-java
Open

feat(storage): add bucket IP filtering samples and tests#14328
nidhiii-27 wants to merge 4 commits into
mainfrom
samples-bucket-ip-filter-java

Conversation

@nidhiii-27

@nidhiii-27 nidhiii-27 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Add Java code samples and integration tests demonstrating Cloud Storage Bucket IP filtering:

  • Create bucket with initial IP filtering rules pre-configured (CreateBucketIpFilter.java)
  • Enable and update IP filtering configuration (EnableBucketIpFilter.java)
  • Get active IP filtering rules (GetBucketIpFilter.java)
  • Delete specific IP filter rules and VPC network sources (DeleteBucketIpFilter.java)
  • Disable IP filtering on a bucket (DisableBucketIpFilter.java)
  • List buckets with IP filtering status (ListBucketsIpFilter.java)
  • Integration test lifecycle suite (IpFilterTest.java)

Fixes: b/544985518

@nidhiii-27
feat(storage): add bucket IP filtering samples and tests
b9dce71 
Add Java code samples and integration tests demonstrating Cloud Storage Bucket IP filtering.

Fixes: b/544985518

[Generated-by: AI]
@nidhiii-27 nidhiii-27 added ai-generated storage-sample-architect Generated by storage-sample-architect skill labels Sep 9, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several Java code snippets and an integration test demonstrating how to manage GCS bucket IP filtering configurations. Specifically, it adds functionality to create, enable, disable, retrieve, list, and delete IP filtering rules on a bucket. Since there are no review comments, I have no feedback to provide.

@nidhiii-27
nidhiii-27 marked this pull request as ready for review September 9, 2026 08:53
@nidhiii-27
nidhiii-27 requested review from a team as code owners September 9, 2026 08:53
@snippet-bot

snippet-bot Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Dhriti07
Dhriti07 reviewed Sep 17, 2026
View reviewed changes
Comment thread java-storage/samples/snippets/src/test/java/com/example/storage/bucket/IpFilterTest.java Outdated
public class IpFilterTest extends TestBase {

@Test
public void testBucketIpFilterLifecycle() throws Exception {

@Dhriti07 Dhriti07 Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we break this lifecycle test into smaller tests. We should generally try sticking to one behavior per test go/tott/726 so its easier to debug if one specific step fails.

@nidhiii-27 nidhiii-27 Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Co-authored by AI Agent

Dhriti07
Dhriti07 reviewed Sep 17, 2026
View reviewed changes
Comment thread ...-storage/samples/snippets/src/main/java/com/example/storage/bucket/DeleteBucketIpFilter.java Outdated
vpcSources.addAll(ipFilter.getVpcNetworkSources());
}
if (vpcNetworkToDelete != null) {
Iterator<VpcNetworkSource> iterator = vpcSources.iterator();

@Dhriti07 Dhriti07 Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify the explicit Iterator loop here by calling removeIf directly on the vpcSources list ?

@nidhiii-27 nidhiii-27 Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Co-authored by AI Agent

@nidhiii-27
fix(storage): resolve PR comments for bucket IP filtering samples
e63a822 
- Simplify VPC network source removal in DeleteBucketIpFilter using removeIf
- Break IpFilterTest lifecycle test into individual single-behavior unit/integration tests

[Generated-by: AI]
@nidhiii-27
fix(storage): merge main to resolve Kokoro SCM checkout failure
596323f 
Synchronize samples-bucket-ip-filter-java with main to resolve the Kokoro
FetchFromGithub SCM checkout failure on PR #14328.

[Generated-by: AI]
@nidhiii-27
Merge branch 'main' into samples-bucket-ip-filter-java
92ff60a
@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dhriti07 Dhriti07 Dhriti07 left review comments
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-generated storage-sample-architect Generated by storage-sample-architect skill

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nidhiii-27 @Dhriti07 @yoshi-kokoro