Repository navigation
impl(auth): check GOOGLE_CLOUD_CPP_HAVE_OPENSSL in ssl_ec_curves - #16579
Merged
scotthart merged 3 commits intoOct 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds conditional compilation guards (GOOGLE_CLOUD_CPP_HAVE_OPENSSL) around OpenSSL headers and the AvailableCryptoGroups function in ssl_ec_curves.cc. However, the review highlights that OpenSslDeleter also uses OpenSSL types and remains unguarded, which will cause compilation failures when OpenSSL is disabled. The entire implementation of OpenSslDeleter should also be guarded.
colinmoy
approved these changes
Oct 20, 2026
scotthart
enabled auto-merge (squash)
October 20, 2026 18:00
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16579 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 2266 2266
Lines 219636 219636
=======================================
+ Hits 202935 202943 +8
+ Misses 16701 16693 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in environments that do not have OpenSSL, don't try to use it.