Skip to content

impl(auth): check GOOGLE_CLOUD_CPP_HAVE_OPENSSL in ssl_ec_curves - #16579

Merged
scotthart merged 3 commits into
googleapis:mainfrom
scotthart:ec_curves_check_have_openssl
Oct 20, 2026
Merged

scotthart merged 3 commits into
googleapis:mainfrom
scotthart:ec_curves_check_have_openssl

Conversation

@scotthart

Copy link
Copy Markdown
Member

When in environments that do not have OpenSSL, don't try to use it.

@scotthart
scotthart requested a review from a team as a code owner October 20, 2026 16:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds conditional compilation guards (GOOGLE_CLOUD_CPP_HAVE_OPENSSL) around OpenSSL headers and the AvailableCryptoGroups function in ssl_ec_curves.cc. However, the review highlights that OpenSslDeleter also uses OpenSSL types and remains unguarded, which will cause compilation failures when OpenSSL is disabled. The entire implementation of OpenSslDeleter should also be guarded.

Comment thread google/cloud/internal/openssl/ssl_ec_curves.cc
@scotthart
scotthart enabled auto-merge (squash) October 20, 2026 18:00
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (c9a3c69) to head (e07461f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16579   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files        2266     2266           
  Lines      219636   219636           
=======================================
+ Hits       202935   202943    +8     
+ Misses      16701    16693    -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart merged commit 2e97e76 into googleapis:main Oct 20, 2026
71 checks passed

This branch was previously deployed

1 inactive deployment
false — e07461fa Deployed Oct 20, 2026 by scotthart via Save PR ref #12526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants