fix(docs): correct example for GenerateContent using an HTTP URL#610
Open
Daquisu wants to merge 2 commits intogoogleapis:mainfrom
Open
fix(docs): correct example for GenerateContent using an HTTP URL#610Daquisu wants to merge 2 commits intogoogleapis:mainfrom
Daquisu wants to merge 2 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
29c82d5 to
8520e3e
Compare
Author
|
I just fixed the CLA issue - sorry about that |
8520e3e to
bfe6149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current example does not work. It suggests one can directly create a
genai.Partfrom an image URL such ashttps://storage.googleapis.com/cloud-samples-data/generative-ai/image/scones.jpg, but it is not possible.One workaround is to download the file and store it in-memory, so we can create a
genai.Partfrom the bytes of a file. This is done in the example for document processing using the same Go SDK: https://ai.google.dev/gemini-api/docs/document-processing#inline_dataI created a repo to show that the current example does not work, and the new example provided by this PR works. See https://github.com/Daquisu/go-genai-example