fix: preserve metadata on batch inlined responses#607
Open
volkan wants to merge 5 commits intogoogleapis:mainfrom
Open
fix: preserve metadata on batch inlined responses#607volkan wants to merge 5 commits intogoogleapis:mainfrom
volkan wants to merge 5 commits intogoogleapis:mainfrom
Conversation
Author
|
Hello @Sivasankaran25 any update on this? |
Collaborator
|
Author
|
Hello @Sivasankaran25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK’s InlinedResponse type in types.go does not define a Metadata field, even though the REST InlinedResponse message has metadata alongside the response/error union. With this fix we will be able to batch
Response contained metadata:

With this change we will be able to get metadata to match jobs easily.