Conversation
aomarks
force-pushed
the
release
branch
2 times, most recently
from
d46fe98 to
720d350
Compare
- Drop Node 18 from CI matrix (EOL since April 2025) - Add a pre-build job using Node 22 to populate wireit cache, avoiding TypeScript 6's extremely slow compilation on Node 18/20 - Skip pnpm tests on Node <22 (pnpm 11 requires Node >=22.13) - Update engines.node from >=18.0.0 to >=20.0.0
The test:cache-github-real step hangs when multiple concurrent CI runs compete for the same GitHub Actions cache keys. Adding a 10-minute step timeout prevents it from consuming the entire 40-minute job timeout.
The test:cache-github-real step hangs when concurrent CI runs compete for the same GitHub Actions cache keys. With continue-on-error, the job still reports success when the main tests pass, even if this supplementary cache test times out.
rictic
approved these changes
Jun 23, 2026
| reject(new Error(`tar error: ${String(error as Error)}`)); | ||
| const message = | ||
| error instanceof Error ? error.message : JSON.stringify(error); | ||
| reject(new Error(`tar error: ${message}`)); |
Member
There was a problem hiding this comment.
Here and elsewhere, consider:
new Error(`tar error: ${message}`, {cause: error})| const connection = createConnection(ProposedFeatures.all); | ||
|
|
||
| connection.onInitialize((init) => { | ||
| connection.onInitialize((init: InitializeParams) => { |
Member
There was a problem hiding this comment.
Huh, surprising! Why do we need to annotate these all of a sudden?
Member
Author
There was a problem hiding this comment.
Oops, we didn't actually need them, it was a red herring from a different error migrating to ts 6.
The explicit callback parameter annotations were added while debugging an import path issue (node.js vs node) during the vscode-languageserver v9 to v10 upgrade. The annotations are not needed — inference works correctly with v10 + nodenext.
aomarks
added a commit
that referenced
this pull request
Jun 23, 2026
aomarks
added a commit
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.