Conversation
…nchers - Set default EOS_TOKENS='151645,151643' in launcher.sh (previously defaulted to empty) - Define and export default EOS_TOKENS in k8s_launcher.sh - Plumb --eos_tokens to run_rollout_node in k8s_launcher.sh - Display eos tokens in launcher.sh startup banner
andytwigg
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
September 19, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR configures default
EOS_TOKENSand plumbs them to rollout nodes for DeepSWE distributed RL runs (both local and GKE k8s), aligning with the pattern established inmath_gsm8k_dist.Problem
tunix/experimental/examples/deepswe_dist/launcher.sh,EOS_TOKENSdefaulted to empty string (${EOS_TOKENS-}), so--eos_tokenswas never passed torun_rollout_node.mainunless manually set in the environment.tunix/experimental/examples/deepswe_dist/k8s_launcher.sh,EOS_TOKENSwas neither declared nor passed instart_rollout().Qwen3-1.7B,Qwen3-4B,Qwen3.5-35B-A3B) finish assistant turns with<|im_end|>(token151645), while<|endoftext|>is token151643. Without151645configured as an EOS token, vLLM fails to stop at the end of turns during rollouts, generating up toMAX_RESPONSE_LENGTHtokens (e.g. 61,440 tokens), hallucinating additional turns, and causing trajectory timeouts.Changes
tunix/experimental/examples/deepswe_dist/launcher.sh:EOS_TOKENS=${EOS_TOKENS-'151645,151643'}.eos tokensin startup banner.tunix/experimental/examples/deepswe_dist/k8s_launcher.sh:export EOS_TOKENS=${EOS_TOKENS-'151645,151643'}.${EOS_TOKENS:+--eos_tokens=\"${EOS_TOKENS}\"} \intorun_rollout_node.mainstartup command.Verification
bash -n).--dry-run:--eos_tokens="151645,151643".EOS_TOKENS=""omits--eos_tokens.EOS_TOKENSis correctly passed.