Decouple Trajectory Store protocols and store backends from Tunix-specific abstractions (TunixTrajectoryMetadata, TunixTrajectory, TunixAgentStep, and TunixEnvStep): - #2281
Open
copybara-service[bot] wants to merge 1 commit into
Conversation
…cific abstractions (TunixTrajectoryMetadata, TunixTrajectory, TunixAgentStep, and TunixEnvStep):
- Parameterize TrajectoryReader, TrajectoryWriter, and TrajectoryStore using TypeVar('T', bound=TrajectoryMetadata) and TypeVar('TrajT', bound=TrajectoryMetadata).
- Add a polymorphic `create_trajectory` factory method on TrajectoryMetadata and TunixTrajectoryMetadata to construct full Trajectory instances polymorphically.
- Remove Tunix-specific imports, `isinstance` branches, and static type ignores from InMemoryTrajectoryStore and FileTrajectoryStore.
- In FileTrajectoryStore, load step data directly as dictionaries and pass them to the trajectory factory, allowing Pydantic's recursive field validation to automatically instantiate the concrete step models (e.g., TunixAgentStep vs. TunixEnvStep) without requiring manual step type configurations.
- Add test cases in in_memory_store_test.py and file_store_test.py covering step_id=0 Tunix trajectories and custom TrajectoryMetadata/Trajectory subclasses.
PiperOrigin-RevId: 983429942
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple Trajectory Store protocols and store backends from Tunix-specific abstractions (TunixTrajectoryMetadata, TunixTrajectory, TunixAgentStep, and TunixEnvStep):
create_trajectoryfactory method on TrajectoryMetadata and TunixTrajectoryMetadata to construct full Trajectory instances polymorphically.isinstancebranches, and static type ignores from InMemoryTrajectoryStore and FileTrajectoryStore.