Merged
Conversation
Instead of 1.13.0 exactly since we're usually running the latest in our dev stack
Plus add it to CI so our CI setup matches what we do in images
Temikus
force-pushed
the
static-assets-2
branch
from
6454b19 to
7d5e15c
Compare
nerdinary
reviewed
Nov 5, 2020
Collaborator
nerdinary
left a comment
nerdinary
left a comment
There was a problem hiding this comment.
"go-bindata" to generate the static data is causing travis ci to fail.
Temikus
force-pushed
the
static-assets-2
branch
3 times, most recently
from
dae81ba to
06b5242
Compare
To make the app self-contained. Build tool changes are driven by the need to require `go-bindata`. This approach is also cleaner than just running `go mod tidy` on every CI run before the diff.
Temikus
force-pushed
the
static-assets-2
branch
from
06b5242 to
9c10226
Compare
nerdinary
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at static assets bundling, this time with no bundling extra deps with the package.
TODO added to replace with embed.FS when it is released as a part of Go stdlib