deploy: sam-one sandbox summary join command needs --bind-addr "" - #365
Merged
Merged
Conversation
Without it sam-node's local API also binds TCP 127.0.0.1:8080, which is fatal at startup unless SAM_API_TOKEN is set; socket-only mode needs no token.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The join command printed in the sandbox job summary fataled on a fresh machine:
sam-node's local API defaults to TCP127.0.0.1:8080, which refuses to start withoutSAM_API_TOKEN/mTLS.--bind-addr ""serves the local API only on the Unix socket, where owner-only permissions replace the token. The summary line now also points at theSAM_API_TOKENalternative.