deploy: define sam:role:node in the seeded policy and fail loudly on … - #363
Merged
Merged
Conversation
…rejection The policy seed bound sam:role:node without defining the role, and /policies validation (strict since the GHSA-cgmg fixes) rejects bindings to undefined roles - but the seeding curl was -s with no -f, so the 400 vanished, the stale policy stayed, and every canary node got 403 'requested role is not bound to this identity' at /register. Reproduced and fixed against the live bananas control plane; the role carries no grants of its own (access still comes from public-mesh), it is purely the explicit open-enrollment seat. curl -fsS now aborts the deploy with a message naming the consequence.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rejection
The policy seed bound sam:role:node without defining the role, and /policies validation (strict since the GHSA-cgmg fixes) rejects bindings to undefined roles - but the seeding curl was -s with no -f, so the 400 vanished, the stale policy stayed, and every canary node got 403 'requested role is not bound to this identity' at /register. Reproduced and fixed against the live bananas control plane; the role carries no grants of its own (access still comes from public-mesh), it is purely the explicit open-enrollment seat. curl -fsS now aborts the deploy with a message naming the consequence.