Hide PbList and PbMap constructors #1072
                
     Draft
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
PbListandPbMapcan't be constructed by the users properly, because theconstructor arguments are private:
PbListelement check functionPbMapkey and value field type argumentsInternally we had just one
PbMapconstructor call (with random field typearguments) which we replaced with
{}, and a fewPbListconstructor calls(without a check function) which we replaced with
[].To prevent confusion and incorrect uses of these types, hide the constructors.
Some of the
PbListelement validation tests are removed: they would need tobe moved to
protoc_plugin/testas we no longer have access toPbListconstructors (but we can get
PbLists from messages), but the tests are alsoduplicates of the tests in
protoc_plugin/test/validate_fail_test.dart. Soremoved them instead.