Skip to content

Commit

Permalink
drop legacy tests
Browse files Browse the repository at this point in the history
kevmoo committed Mar 6, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
binghe Chun Tian
1 parent f4f14c9 commit 3eaf741
Showing 4 changed files with 7 additions and 171 deletions.
65 changes: 6 additions & 59 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
@@ -240,7 +240,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test_0"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test"
restore-keys: |
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
@@ -277,7 +277,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin;commands:command_0-command_3-test_0"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin;commands:command_0-command_3-test"
restore-keys: |
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
@@ -322,7 +322,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test_0"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test"
restore-keys: |
os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf
os:ubuntu-latest;pub-cache-hosted;sdk:dev
@@ -359,7 +359,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:command_0-command_3-test_0"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:command_0-command_3-test"
restore-keys: |
os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin
os:ubuntu-latest;pub-cache-hosted;sdk:dev
@@ -404,7 +404,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:macos-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test_0"
key: "os:macos-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf;commands:test"
restore-keys: |
os:macos-latest;pub-cache-hosted;sdk:3.3.0;packages:protobuf
os:macos-latest;pub-cache-hosted;sdk:3.3.0
@@ -441,7 +441,7 @@ jobs:
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:macos-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test_0"
key: "os:macos-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test"
restore-keys: |
os:macos-latest;pub-cache-hosted;sdk:dev;packages:protobuf
os:macos-latest;pub-cache-hosted;sdk:dev
@@ -524,56 +524,3 @@ jobs:
- job_004
- job_005
- job_006
job_015:
name: "run_legacy_tests; linux; Dart 3.3.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test legacy_tests/generated_message_test.dart`"
runs-on: ubuntu-latest
steps:
- name: Cache Pub hosted dependencies
uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319
with:
path: "~/.pub-cache/hosted"
key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin;commands:command_0-command_3-test_1"
restore-keys: |
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0;packages:protoc_plugin
os:ubuntu-latest;pub-cache-hosted;sdk:3.3.0
os:ubuntu-latest;pub-cache-hosted
os:ubuntu-latest
- name: Setup Dart SDK
uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
with:
sdk: "3.3.0"
- id: checkout
name: Checkout repository
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
- id: protoc_plugin_pub_upgrade
name: protoc_plugin; dart pub upgrade
run: dart pub upgrade
if: "always() && steps.checkout.conclusion == 'success'"
working-directory: protoc_plugin
- name: protoc_plugin; ./../tool/setup.sh
run: ./../tool/setup.sh
if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'"
working-directory: protoc_plugin
- name: protoc_plugin; make protos
run: make protos
if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'"
working-directory: protoc_plugin
- name: protoc_plugin; dart test legacy_tests/generated_message_test.dart
run: dart test legacy_tests/generated_message_test.dart
if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'"
working-directory: protoc_plugin
needs:
- job_001
- job_002
- job_003
- job_004
- job_005
- job_006
- job_007
- job_008
- job_009
- job_010
- job_011
- job_012
- job_013
- job_014
101 changes: 0 additions & 101 deletions protoc_plugin/legacy_tests/generated_message_test.dart

This file was deleted.

6 changes: 0 additions & 6 deletions protoc_plugin/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -14,9 +14,3 @@ stages:
- command: make protos
- test
sdk: [pubspec, dev]
- run_legacy_tests:
- group:
- command: ./../tool/setup.sh
- command: make protos
- test: legacy_tests/generated_message_test.dart
sdk: [pubspec]
6 changes: 1 addition & 5 deletions tool/ci.sh
Original file line number Diff line number Diff line change
@@ -99,14 +99,10 @@ for PKG in ${PKGS}; do
echo 'dart format --output=none --set-exit-if-changed .'
dart format --output=none --set-exit-if-changed . || EXIT_CODE=$?
;;
test_0)
test)
echo 'dart test'
dart test || EXIT_CODE=$?
;;
test_1)
echo 'dart test legacy_tests/generated_message_test.dart'
dart test legacy_tests/generated_message_test.dart || EXIT_CODE=$?
;;
*)
echo -e "\033[31mUnknown TASK '${TASK}' - TERMINATING JOB\033[0m"
exit 64

0 comments on commit 3eaf741

Please sign in to comment.