Implementation of Wordpress plugins packages Extractor #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpasdf
reviewed
Jan 7, 2025
vpasdf
reviewed
Jan 7, 2025
vpasdf
reviewed
Jan 7, 2025
vpasdf
reviewed
Feb 5, 2025
vpasdf
reviewed
Feb 5, 2025
vpasdf
reviewed
Feb 7, 2025
vpasdf
reviewed
Feb 10, 2025
| wantResultMetric stats.FileRequiredResult | ||
| }{ | ||
| { | ||
| name: "wp-content/plugins/foo/test.php file", |
There was a problem hiding this comment.
Make sure sub test names are formatted such that you can search for the escaped sub test name in code. I.e. spaces are not allowed.
vpasdf
reviewed
Feb 10, 2025
| @@ -81,4 +83,4 @@ SCALIBR supports extracting software package information from a variety of OS an | |||
| * SPDX SBOM descriptors | |||
| * CycloneDX SBOM descriptors | |||
|
|
|||
| If you're a SCALIBR user and are interested in having it support new inventory types we're happy to accept contributions. See the docs on [how to add a new Extractor](/docs/new_extractor.md). | |||
| If you're a SCALIBR user and are interested in having it support new inventory types we're happy to accept contributions. See the docs on [how to add a new Extractor](/docs/new_extractor.md). | |||
There was a problem hiding this comment.
Is this line changed in this PR? I guess not and it should not.
There was a problem hiding this comment.
Please revert this line if possible
There was a problem hiding this comment.
This is because of a new line was removed here, but github doesn't show it for some reason. Still should be reverted though.
vpasdf
reviewed
Feb 10, 2025
| @@ -60,6 +60,7 @@ import ( | |||
| "github.com/google/osv-scalibr/extractor/filesystem/language/ruby/gemspec" | |||
| "github.com/google/osv-scalibr/extractor/filesystem/language/rust/cargoauditable" | |||
| "github.com/google/osv-scalibr/extractor/filesystem/language/rust/cargolock" | |||
| "github.com/google/osv-scalibr/extractor/filesystem/language/wordpress/plugins" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the Wordpress plugins packages extractor.
Implemented: