Skip to content

Removed atomic operations from mesh_consistency.save_process_metadata #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Removed atomic operations from mesh_consistency.save_process_metadata #1943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions checkpoint/orbax/checkpoint/experimental/emergency/mesh_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,10 @@
from absl import logging
from etils import epath
import jax
from orbax.checkpoint import options as options_lib
from orbax.checkpoint.experimental.emergency import multihost as emergency_multihost
from orbax.checkpoint.path import atomicity_defaults
from orbax.checkpoint.path import step as step_lib



_PROCESS_METADATA_FOLDER = 'process_metadata'
_PROCESS_METADATA_FILE_NAME = 'process_metadata.json'
_GLOBAL_PROCESS_METADATA_FILE_NAME = 'global_process_metadata.json'
Expand Down Expand Up @@ -76,29 +73,13 @@ async def save_process_metadata(
"""Saves process metadata to local storage. Runs on every process."""
metadata_folder = process_metadata_folder(directory)
logging.info('Saving process index metadata at %s', metadata_folder)
if metadata_folder.exists():
logging.warning(
'Process metadata folder already exists at %s. Overwriting.',
metadata_folder,
)
metadata_folder.rmtree()

multiprocessing_options = options_lib.MultiprocessingOptions(
primary_host=None
)
tmp_path = atomicity_defaults.get_default_temporary_path_class(
metadata_folder
).from_final(metadata_folder, multiprocessing_options=multiprocessing_options)
await tmp_path.create()

(tmp_path.get() / _GLOBAL_PROCESS_METADATA_FILE_NAME).write_text(
(metadata_folder / _GLOBAL_PROCESS_METADATA_FILE_NAME).write_text(
json.dumps(distributed_to_device_ids)
)
(tmp_path.get() / _MESH_METADATA_FILE_NAME).write_text(
(metadata_folder / _MESH_METADATA_FILE_NAME).write_text(
json.dumps([int(id) for id in global_mesh.device_ids.flatten()])
)
tmp_path.finalize(
)


def consistent_restore_mesh_from_metadata(
Expand Down