Skip to content

[buildbot] Adjust gemmlowp_INSTALL_LIBDIR based on CMake's choices #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DataCorrupted
Copy link

Some of our servers default installation to lib64 instead of lib. This patch asks CMakeCache which one did it use.

Copy link

google-cla bot commented Mar 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@petrhosek
Copy link
Collaborator

Rather than relying on the the defaults inferred by the GNUInstallDirs module and reading those out of the CMakeCache.txt file, I think it'd be cleaner to explicitly set CMAKE_INSTALL_BINDIR, CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR .

@DataCorrupted
Copy link
Author

explicitly set CMAKE_INSTALL_LIBDIR

It seems other repos are already doing this, I'll just follow suit and set it to lib instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants