Repository navigation
Reject out-of-range ports in the TCP benchmark proxy - #16543
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
A netstack listen or forwarding port of 65537 wraps to port 1. A bad native forwarding port also makes the proxy retry a connection that cannot succeed. Parse the listen port at its 16-bit width and the netstack destination as a numeric address and port before opening network devices. Check the native forwarding port at startup so permanent errors cannot enter the retry loop. Leave host resolution to each connection attempt. FUTURE_COPYBARA_INTEGRATE_REVIEW=#16345 from tamird:tcp-proxy-port-bounds 641a5c3 PiperOrigin-RevId: 1008492291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject out-of-range ports in the TCP benchmark proxy
A netstack listen or forwarding port of 65537 wraps to port 1. A bad
native forwarding port also makes the proxy retry a connection that
cannot succeed.
Parse the listen port at its 16-bit width and the netstack destination
as a numeric address and port before opening network devices. Check the
native forwarding port at startup so permanent errors cannot enter the
retry loop. Leave host resolution to each connection attempt.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16345 from tamird:tcp-proxy-port-bounds 641a5c3