Repository navigation
benchmark: add Docker-in-gVisor moby network benchmark. - #16445
Open
parth-opensrc wants to merge 1 commit into
Open
parth-opensrc wants to merge 1 commit into
parth-opensrc wants to merge 1 commit into
Conversation
parth-opensrc
force-pushed
the
pr-moby-bench
branch
from
October 26, 2026 21:50
9f37ed9 to
fdc7735
Compare
EtiennePerot
requested changes
Oct 26, 2026
Comment on lines
+53
to
+63
| // EnsureRuntime defaults the container runtime to runsc if unspecified and | ||
| // returns whether the active runtime is gVisor. | ||
| func EnsureRuntime() (bool, error) { | ||
| if dockerutil.Runtime() == "" { | ||
| slog.Warn("no runtime specified, defaulting to runsc") | ||
| dockerutil.SetRuntime("runsc") | ||
| } | ||
| ctx, cancel := context.WithTimeout(context.Background(), time.Minute) | ||
| defer cancel() | ||
| return dockerutil.IsGVisorRuntime(ctx) | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think this is a good idea, especially the sideeffect with the empty runtime. This should inherit the runtime dockerutil dictates, for consistency with the rest of the benchmarks. The StartContainer function can just call dockerutil.IsGVisorRuntime directly. I see this logic was already in moby_test.go, but should disappear.
Comment on lines
+96
to
+102
| // Exec runs a command inside container d and returns an error if it fails. | ||
| func Exec(ctx context.Context, d *dockerutil.Container, args ...string) error { | ||
| if out, err := d.Exec(ctx, dockerutil.ExecOpts{}, args...); err != nil { | ||
| return fmt.Errorf("command %v failed: %w (%s)", args, err, out) | ||
| } | ||
| return nil | ||
| } |
Collaborator
There was a problem hiding this comment.
No need for this function at all, the d.Exec function is already good enough.
Contributor
Author
There was a problem hiding this comment.
Removed custom exec.
parth-opensrc
force-pushed
the
pr-moby-bench
branch
from
October 26, 2026 21:52
fdc7735 to
0606981
Compare
parth-opensrc
force-pushed
the
pr-moby-bench
branch
from
October 27, 2026 17:58
0606981 to
ed92018
Compare
Added benchmark to: - Measure TCP throughput across Docker-in-gVisor (DING) network topologies using iperf. - Topologies: * DING -> DING over loopback (127.0.0.1) * Host -> DING over the host Docker network * DING -> Host over the host Docker network * DING -> DING across two DING containers on the host Docker network * Host -> DINGSubContainer * DINGSubContainer -> Host * DING -> DINGSubContainer over a bridge network * DINGSubContainer -> DING over a bridge network * DINGSubContainer -> DINGSubContainer on the same bridge * DINGSubContainer -> DINGSubContainer over different bridge
parth-opensrc
force-pushed
the
pr-moby-bench
branch
from
October 27, 2026 18:42
ed92018 to
ba67522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added benchmark to measure TCP throughput across
Docker-in-gVisor (DING) network topologies using Iperf.
Topologies: