Repository navigation
Conversation
Metricsviz accepts unsigned 64-bit nanosecond offsets, then converts them to time.Duration. Offsets above MaxInt64 become negative and place samples before the collection start instead of rejecting the invalid log. Limit offsets to the nonnegative time.Duration range and retain the parser's range error. Check both valid endpoints and overflowing values through the existing metrics log parser. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metricsviz accepts unsigned 64-bit nanosecond offsets, then converts them
to time.Duration. Offsets above MaxInt64 become negative and place samples
before the collection start instead of rejecting the invalid log.
Limit offsets to the nonnegative time.Duration range and retain the
parser's range error. Check the valid endpoints and overflowing values
through the existing metrics log parser.
The standalone parser suite passes, but its analyzer build encounters an
existing Docker protobuf dependency error 1. Both analyzer owners pass
for AMD64 and ARM64 with the separate #16098 build-graph correction 2.
This PR contains only the timestamp change.