Go benchstat parser: Support alternate syntax for parameters. #11186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This supports benchmark names where parameter-value pairs are separated by `=` rather than `.`, and benchmarks where `GOMAXPROCS` is not appended to the name of the benchmark. This is used in Kubernetes benchmarks where the `GOMAXPROCS` value of the machine running the Kubernetes client has no bearing on the benchmark's performance. PiperOrigin-RevId: 697040057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go benchstat parser: Support alternate syntax for parameters.
This supports benchmark names where parameter-value pairs are separated
by
=rather than., and benchmarks whereGOMAXPROCSis not appendedto the name of the benchmark.
This is used in Kubernetes benchmarks where the
GOMAXPROCSvalue of themachine running the Kubernetes client has no bearing on the benchmark's
performance.