sentry: use read(2) host syscall to perform read on disk-backed MemoryFiles#11163
sentry: use read(2) host syscall to perform read on disk-backed MemoryFiles#11163dawei-sdw wants to merge 1 commit intogoogle:masterfrom
Conversation
…yFiles The mf.MapInternal()+safemem.CopySeq() approach used right now incurs a lot of page faults without page population. Page-by-page faults incurs a lot of context switching. This commits uses read(2) host syscall instead, which makes one context switch and faults all the pages that are touched during the read. Signed-off-by: Dawei Shen <shendawei.sdw@antgroup.com>
Thank you very much for your comments; it is a very helpful suggestion. I will attach the FIO read benchmark results for reference to commit 0d52b50. |
I mean could you attach FIO benchmark results in the description of this PR? So it is part of git commit history once this is merged. |
Sure, I will attach the FIO benchmark results in the commit log of this PR. I haven't researched the FIO benchmark yet, so I will need to look into it first. |
|
A friendly reminder that this PR had no activity for 120 days. |
3 participants
The mf.MapInternal()+safemem.CopySeq() approach used right now incurs a lot of page faults without page population. Page-by-page faults incurs a lot of context switching. This commits uses read(2) host syscall instead, which makes one context switch and faults all the pages that are touched during the read.