This repository was archived by the owner on Feb 15, 2023. It is now read-only.
performance: declare gumbo_debug as inline function #383
+14
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using the perf profiler on user space to benchmark gumbo_parser at Centos6.5 as the following:
It shows the gumbo_debug function will occupy approximate %1.10 On-CPU at


retq
instruction.and
To eliminate the overhead of function call even if it's compiled on release mode, gumbo_debug should be declared as inline function.
Also apply @stevecheckoway's PR #378 to pass CI.
@nostrademons Can you have a look at it ? Many thanks !