Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize failureaccess. #7671

Closed
wants to merge 0 commits into from
Closed

Modularize failureaccess. #7671

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Modularize failureaccess.

This is the next piece of #7094, which is progress toward modularization.

I've modified this CL somewhat from the original version so that I can deploy a new version of failureaccess without needing to make any updates to guava-parent first. failureaccess does still use guava-parent (and I've bumped it to use the newest released version) for its configuration for Sonatype, Javadoc, etc. But I've inlined all the configuration that I need for the modularization.

I did note a few differences from the original version:

  • This version includes LICENSE under META-INF, both in the main jar and in the sources jars.
  • This version uses a different configuration for Javadoc, I assume because my recent changes there didn't make it into 33.4.0.

I also notice that neither version contains module-info.java in its source jar. We could presumably fix that in the future if anyone is interested.

(And while this isn't strictly related, I do notice that we could consider also releasing a modularized version of listenablefuture someday.)

I have tested with:

$ JAVA_HOME=$HOME/.m2/jdks/jdk-17.0.13+11 ./mvnw clean install -Psonatype-oss-release -Dmaven.test.redirectTestOutputToFile=true -Dsurefire.printSummary=false -Drelease -f futures/failureaccess

(Some of those flags aren't necessary, but I found it easiest to copy what our release script does for "normal" releases.)

I would use deploy instead of install for the real thing.

Relates-To: elide-dev/jpms#1
Signed-off-by: Sam Gammon [email protected]
RELNOTES=Changed the failureaccess jar to be a modular jar.

@copybara-service copybara-service bot closed this Feb 12, 2025
@copybara-service copybara-service bot deleted the test_725708714 branch February 12, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants