Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modularize
failureaccess
.This is the next piece of #7094, which is progress toward modularization.
I've modified this CL somewhat from the original version so that I can deploy a new version of
failureaccess
without needing to make any updates toguava-parent
first.failureaccess
does still useguava-parent
(and I've bumped it to use the newest released version) for its configuration for Sonatype, Javadoc, etc. But I've inlined all the configuration that I need for the modularization.I did note a few differences from the original version:
LICENSE
underMETA-INF
, both in the main jar and in the sources jars.I also notice that neither version contains
module-info.java
in its source jar. We could presumably fix that in the future if anyone is interested.(And while this isn't strictly related, I do notice that we could consider also releasing a modularized version of
listenablefuture
someday.)I have tested with:
(Some of those flags aren't necessary, but I found it easiest to copy what our release script does for "normal" releases.)
I would use
deploy
instead ofinstall
for the real thing.Relates-To: elide-dev/jpms#1
Signed-off-by: Sam Gammon [email protected]
RELNOTES=Changed the
failureaccess
jar to be a modular jar.