Add GTEST_HAS_ABSL support into gmock cmake for MSVC #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added conditional compilation definitions for GTEST_HAS_ABSL in MSVC configuration. * Configured and linked Abseil and RE2 dependencies when GTEST_HAS_ABSL is enabled.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change
When building with MSVC, the sources of
gtestare included directly ingmockrather than linking togtestas a separate library. This resulted inGTEST_HAS_ABSLnot being defined, causinggmockto miss linking with the necessary Abseil and RE2 libraries.How this change fix this issue
GTEST_HAS_ABSLwhen building with MSVC.gmockandgmock_mainto link with Abseil and RE2 dependencies explicitly.GTEST_HAS_ABSLand specifying the required libraries, thus resolving build and runtime issues.