Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back support for platformio #4265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Jun 1, 2023

The version of googletest available to the Platformio framework is stale due to the removal of the library.json file from the googletest repo. To continue to support this community, it would be nice if we could add this file back.

Added back support for PlatformIO.
@higher-performance higher-performance requested review from asoffer and removed request for asoffer June 5, 2023 19:40
@asoffer
Copy link
Contributor

asoffer commented Jun 6, 2023

Do you have thoughts on how this can be kept up to date/tested? We do not have any experience with platformio and are not well-poised to maintain this. Is it critical that this file be in this git repository, or could it be maintained elsewhere?

@ciband
Copy link
Contributor Author

ciband commented Jun 6, 2023

When the feature was first added, I also added CI tests that would at least compile the code to make sure it builds. Running the googletest unit tests would be impractical as we would need to run them on the target embedded hardware. I could certainly create a follow up PR to add those CI tests back.

If the library.json is stored in the repo, then the process for maintaining the library would be to update its version and any relevant changes to the include/exclude files, and then re-publish it with the PlatformIO framework.

Details on that here: https://docs.platformio.org/en/latest/librarymanager/creating.html#publishing

A future state could potentially automate this step as a part of the googletest CI/CD pipeline when you guys do releases.

If the file is not in this repo, then it would just have to be maintained locally and manually republished every time a googletest released.

@ciband
Copy link
Contributor Author

ciband commented Jun 20, 2023

@asoffer, is there anything else you need for this PR, or are there any other questions I can answer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants