Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quote in args-file(s) #485

Closed
wants to merge 2 commits into from
Closed

Conversation

aharonha
Copy link

Fixes #421
To use this feature put this in your file:

@"C:\Users\User name\git\project\filename.jar"

aharonha added 2 commits May 19, 2020 09:20
fixes google#421

arg file now supports
`@"C:\Users\User name\folder\file.java"`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cushon cushon closed this Aug 11, 2021
@kfriedberger
Copy link

I just found this old PR #485 when creating a new PR for a similar topic: #931 .

Just a comment on this PR #485 here (I know it is quite old, but maybe someone reads it):
The change here solves only half of the issue, e.g., whitespaces in the parameter for the @-file itself are allowed.
However, this ignores any other parameter with whitespaces, like filenames for sourcefiles, and (from a user's perspective) it is unexpected that the quotes appear only after the @-symbol, like @"some file", and not around the complete parameter, like "@some file" or "some other param".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to format files with a space in the path
4 participants