Skip to content

Added JUnit Test Cases for Replacement #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

surajdm123
Copy link

@surajdm123 surajdm123 commented Jul 3, 2025

Changes

This PR adds the missing unit test case for Replacement.

Test Plan

mvn -Dtest=ReplacementTest test

...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.googlejavaformat.java.ReplacementTest
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 s - in com.google.googlejavaformat.java.ReplacementTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0

mvn test

Screenshot 2025-07-03 at 1 53 39 AM

Next Steps

  • Add more missing test cases to make this codebase more resilient.

@surajdm123
Copy link
Author

@cushon Can you please review this?

@surajdm123
Copy link
Author

surajdm123 commented Jul 16, 2025

@cushon , would you be able to help with this please? 🙏

@Pankraz76

This comment was marked as resolved.

@jbduncan
Copy link
Contributor

@Pankraz76 OpenRewrite has its own flaws, too, like a slow Gradle plugin and a not-fully open source ecosystem of recipes, so I'd recommend google-java-format or Palantir's fork for formatting purposes in the meantime.

@Pankraz76

This comment was marked as resolved.

@Pankraz76
Copy link

sorry my not being nice and patient it seems all fine. Maybe just vacay or something.

Please excuse and enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants