Implemented and Tested Clear. #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some code spacing.
josephlr
reviewed
Jul 22, 2022
|
|
||
| if _, err := clear.Execute(thetpm); err != nil { | ||
| t.Fatalf("Clear failed: %v", err) | ||
| } |
There was a problem hiding this comment.
Is it possible to have some observable affect here? I know TPM2_Clear does multiple things, would it be possible to observe one of them?
There was a problem hiding this comment.
You could generate a primary key in the storage hierarchy with the same template before and after the clear, and assert the public part changed.
matt-tsai
changed the title
|
Added this with the requested test in #305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented and tested Clear. Fixed some code spacing. Clear will be helping in testing other functions so more comprehensive tests will come with the migration of more features.