Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
# Only check notebooks modified in this pull request
readarray -t changed_notebooks < <(git diff --name-only main | grep '\.ipynb$' || true)
readarray -t changed_notebooks < <(git diff --name-only main --diff-filter="d" | grep '\.ipynb$' || true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, exclude deleted files from the notebook check? Sounds good to me.

However, it looks like the syntax for diff-filter does not include quotes (""). Should be:

--diff-filter=d

reference: https://git-scm.com/docs/git-diff#Documentation/git-diff.txt-code--diff-filterACDMRTUXBcode

else
# Manual run, check everything
readarray -t changed_notebooks < <(find -name '*.ipynb')
Expand Down