Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacquard 12 Charted: Version 1.000 added #7300

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

emmamarichal
Copy link
Collaborator

f4bb5af: [gftools-packager] Jacquard 12 Charted: Version 1.000 added

4da0a25: Description and metadatas updated

@emmamarichal emmamarichal linked an issue Feb 21, 2024 that may be closed by this pull request
9 tasks
@emmamarichal emmamarichal requested a review from m4rc1e February 21, 2024 13:33
Copy link

FontBakery report

fontbakery version: 0.12.0a1

Check results

[22] Jacquard12Charted-Regular.ttf
🔥 FAIL: Whitespace glyphs have ink? (com.google.fonts/check/whitespace_ink)
  • 🔥 FAIL Glyph 'space' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
  • 🔥 FAIL Glyph 'uni200A' has ink. It needs to be replaced by an empty glyph. [code: has-ink]
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1260 when it should be at least 1512 [code: bad-hhea-range]
WARN: Checking unitsPerEm value is reasonable. (com.google.fonts/check/unitsperem)
  • WARN In order to optimize performance on some legacy renderers, the value of unitsPerEm at the head table should idealy be a power of between 16 to 16384. And values of 1000 and 2000 are also common and may be just fine as well. But we got 1260 instead. [code: suboptimal]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • d.alt

    • g.alt

    • h.alt

    • k.alt

    • q.alt

    • s.alt

    • uni030C.alt

    • y.alt
      [code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: space	Contours detected: 85	Expected: 0

- Glyph name: exclam	Contours detected: 63	Expected: 2

- Glyph name: quotedbl	Contours detected: 95	Expected: 2

- Glyph name: numbersign	Contours detected: 186	Expected: 2

- Glyph name: dollar	Contours detected: 113	Expected: 1, 3 or 5

- Glyph name: percent	Contours detected: 174	Expected: 4 or 5

- Glyph name: ampersand	Contours detected: 201	Expected: 1, 2 or 3

- Glyph name: quotesingle	Contours detected: 39	Expected: 1

- Glyph name: parenleft	Contours detected: 82	Expected: 1

- Glyph name: parenright	Contours detected: 84	Expected: 1

- 647 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 540 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 480:
greater, less

Width = 420:
multiply
[code: width-outliers]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (com.google.fonts/check/alt_caron)
  • WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Mango (Latn, 77,000 speakers), Igbo (Latn, 27,823,640 speakers), Ngbaka (Latn, 1,020,000 speakers), Aghem (Latn, 38,843 speakers), Southern Kisi (Latn, 360,000 speakers), Zapotec (Latn, 490,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Koonzime (Latn, 40,000 speakers), South Central Banda (Latn, 244,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Gulay (Latn, 250,478 speakers), Bete-Bendi (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ejagham (Latn, 120,000 speakers), Cicipu (Latn, 44,000 speakers), Ebira (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mfumte (Latn, 79,000 speakers), Kom (Latn, 360,685 speakers), Bafut (Latn, 158,146 speakers), Avokaya (Latn, 100,000 speakers), Nzakara (Latn, 50,000 speakers), Dan (Latn, 1,099,244 speakers), Lugbara (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Dii (Latn, 71,000 speakers), Sar (Latn, 500,000 speakers), Makaa (Latn, 221,000 speakers), Ma’di (Latn, 584,000 speakers), Fur (Latn, 1,230,163 speakers), Yala (Latn, 200,000 speakers), Mundani (Latn, 34,000 speakers), Basaa (Latn, 332,940 speakers), Ekpeye (Latn, 226,000 speakers). [code: soft-dotted]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0020 SPACE: try adding one of: javanese, old-north-arabian, meroitic-hieroglyphs, cypro-minoan, bengali, malayalam, rejang, runic, shavian, tagalog, grantha, lycian, chinese-traditional, makasar, nko, chinese-simplified, mandaic, avestan, linear-b, masaram-gondi, old-persian, elymaic, mongolian, toto, marchen, yezidi, takri, tai-le, miao, tagbanwa, syriac, ol-chiki, glagolitic, samaritan, ethiopic, yi, deseret, sundanese, khmer, nabataean, osage, chorasmian, music, cherokee, znamenny, buginese, meetei-mayek, pau-cin-hau, inscriptional-parthian, nushu, hatran, kharoshthi, lepcha, tibetan, phoenician, old-turkic, armenian, cyrillic, khitan-small-script, gurmukhi, braille, bassa-vah, hebrew, vietnamese, tamil-supplement, thaana, dives-akuru, signwriting, ugaritic, batak, limbu, thai, soyombo, pahawh-hmong, khojki, zanabazar-square, tai-tham, khudawadi, ogham, old-sogdian, cham, chinese-hongkong, georgian, lydian, balinese, old-hungarian, kawi, new-tai-lue, duployan, indic-siyaq-numbers, gujarati, lao, vai, wancho, telugu, osmanya, kayah-li, nandinagari, mahajani, nyiakeng-puachue-hmong, old-uyghur, egyptian-hieroglyphs, buhid, adlam, psalter-pahlavi, cyrillic-ext, old-south-arabian, cuneiform, sogdian, anatolian-hieroglyphs, tai-viet, warang-citi, hanunoo, kannada, cypriot, ottoman-siyaq-numbers, tangsa, tifinagh, greek-ext, meroitic-cursive, vithkuqi, japanese, modi, coptic, newa, imperial-aramaic, dogra, myanmar, gunjala-gondi, manichaean, mayan-numerals, medefaidrin, canadian-aboriginal, bhaiksuki, meroitic, elbasan, gothic, kaithi, greek, tamil, caucasian-albanian, tirhuta, sora-sompeng, chakma, siddham, phags-pa, saurashtra, korean, brahmi, old-italic, syloti-nagri, bamum, multani, devanagari, nag-mundari, carian, hanifi-rohingya, oriya, sharada, arabic, old-permic, sinhala, ahom, linear-a, lisu, mro, tangut, mende-kikakui, inscriptional-pahlavi, palmyrene

  • U+00A0 NO-BREAK SPACE: try adding one of: javanese, old-north-arabian, meroitic-hieroglyphs, cypro-minoan, bengali, malayalam, rejang, runic, shavian, tagalog, grantha, lycian, chinese-traditional, makasar, nko, chinese-simplified, mandaic, avestan, linear-b, masaram-gondi, old-persian, elymaic, mongolian, toto, marchen, yezidi, takri, tai-le, miao, tagbanwa, syriac, ol-chiki, glagolitic, samaritan, ethiopic, yi, deseret, sundanese, khmer, nabataean, osage, chorasmian, music, cherokee, znamenny, buginese, meetei-mayek, pau-cin-hau, inscriptional-parthian, nushu, hatran, kharoshthi, lepcha, tibetan, phoenician, old-turkic, armenian, cyrillic, khitan-small-script, gurmukhi, braille, bassa-vah, hebrew, vietnamese, tamil-supplement, thaana, dives-akuru, signwriting, ugaritic, batak, limbu, thai, soyombo, pahawh-hmong, khojki, zanabazar-square, tai-tham, khudawadi, ogham, old-sogdian, cham, chinese-hongkong, georgian, lydian, balinese, old-hungarian, kawi, new-tai-lue, duployan, indic-siyaq-numbers, gujarati, lao, vai, wancho, telugu, osmanya, kayah-li, nandinagari, mahajani, nyiakeng-puachue-hmong, old-uyghur, egyptian-hieroglyphs, buhid, adlam, psalter-pahlavi, cyrillic-ext, old-south-arabian, cuneiform, sogdian, anatolian-hieroglyphs, tai-viet, warang-citi, hanunoo, kannada, cypriot, ottoman-siyaq-numbers, tangsa, tifinagh, greek-ext, meroitic-cursive, vithkuqi, japanese, modi, coptic, newa, imperial-aramaic, dogra, myanmar, gunjala-gondi, manichaean, mayan-numerals, medefaidrin, canadian-aboriginal, bhaiksuki, meroitic, elbasan, gothic, kaithi, greek, tamil, caucasian-albanian, tirhuta, sora-sompeng, chakma, siddham, phags-pa, saurashtra, korean, brahmi, old-italic, syloti-nagri, bamum, multani, devanagari, nag-mundari, carian, hanifi-rohingya, oriya, sharada, arabic, old-permic, sinhala, ahom, linear-a, lisu, mro, tangut, mende-kikakui, inscriptional-pahlavi, palmyrene

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
    6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0A
- Use grayscale rendering
- Use smoothing along multiple axes with ClearType®
[code: ranges]

  • WARN The gasp range 0xFFFF value 0x0A should be set to 0x0F. [code: unset-flags]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/jacquard12charted [code: family-path]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
Font(file='ofl/jacquard12charted/Jacquard12Charted-Regular.ttf', context=CheckRunContext(testables=[...], config={'com.google.fonts/check/file_size': {'WARN_SIZE': 1048576, 'FAIL_SIZE': 9437184}, 'custom_order': None, 'explicit_checks': None, 'exclude_checks': None, 'full_lists': False, 'skip_network': False}))
Dehinted Size 572.7kb
Hinted Size 572.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO All of the fonts lack a STAT table.
    [code: summary]

Summary

💔 ERROR ☠ FATAL 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 4 11 63 8 171 0
0% 0% 2% 4% 25% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator Author

@m4rc1e

Some fails explanation:

🔥 FAIL: Whitespace glyphs have ink?
-> This is the charted version with a grid, so it's normal.

🔥 FAIL: Does DESCRIPTION file contain broken links?
-> Normal, the links are those of the other fonts in the family, which are not yet live

🔥 FAIL: Check font follows the Google Fonts vertical metric schema
-> The grid makes the v-metrics special, we can ignore

@emmamarichal emmamarichal marked this pull request as ready for review February 21, 2024 13:40
@m4rc1e m4rc1e merged commit 5c24c29 into main Feb 22, 2024
7 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_jacquard12charted branch February 22, 2024 16:43
@emmamarichal
Copy link
Collaborator Author

blocked because of the menu rendering

@emmamarichal
Copy link
Collaborator Author

@chrissimpkins are the menus ok? can I unblock it?

@chrissimpkins
Copy link
Collaborator

@chrissimpkins are the menus ok? can I unblock it?

Ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Soft Type Jacquard 12 Charted
3 participants