-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
knowledge_graph.py: check outbound links #7288
Conversation
Results I get are:
|
58a7e31
to
4cb1f80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit's but generally LGTM
Edit; ofc please don't submit until CI passes, either by adding a known-failure list or by fixing bad urls.
All fixed in #7291 |
4cb1f80
to
f2069bf
Compare
f2069bf
to
0d83119
Compare
769272b
to
c37a818
Compare
Thanks both of you. Rod, I've implemented as much as your feedback as possible. Dave, thanks for fixing the links! |
Some caveats I need to mention:
--check_outbound_links
in order for it to run.Fixes #7277