-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Madimi: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added #7250
Conversation
… added * Madimi Version 1.000; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/TaVaTake/madimi at commit TaVaTake/madimi@037e703.
FontBakery reportfontbakery version: 0.11.0 Checks with FATAL resultsThese must be addressed first. [1] Madimi-Bold.ttf☠ FATAL: The font has tags in the GF Tags spreadsheet (com.google.fonts/check/metadata/has_tags)
All other checks[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[25] Madimi-Bold.ttf🔥 FAIL: METADATA.pb: According to Google Fonts standards, families should have a Regular style. (com.google.fonts/check/metadata/has_regular)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But: OFL text has 'https://github.com/googlefonts/googlefonts-project-template' and HTML description has 'github.com/youruseraccount/yourrepository' 🔥 FAIL: Directory name in GFonts repo structure must match NameID 1 of the regular. (com.google.fonts/check/repo/dirname_matches_nameid_1)
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 474: Width = 517: Width = 571: Width = 484: ⚠ WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors] ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments] ⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇ į̣̈ į̣̊ į̣̋ į̣̌ į̣̒ į̦̀ į̦́ Your font fully covers the following languages that require the soft-dotted feature: Igbo (Latn, 27,823,640 speakers), Ebira (Latn, 2,200,000 speakers), Ekpeye (Latn, 226,000 speakers), Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Makaa (Latn, 221,000 speakers), Dii (Latn, 71,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Navajo (Latn, 166,319 speakers), Southern Kisi (Latn, 360,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Avokaya (Latn, 100,000 speakers), Mango (Latn, 77,000 speakers), Gulay (Latn, 250,478 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Nzakara (Latn, 50,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Yala (Latn, 200,000 speakers), Cicipu (Latn, 44,000 speakers), Mfumte (Latn, 79,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ejagham (Latn, 120,000 speakers), South Central Banda (Latn, 244,000 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Mundani (Latn, 34,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Dan (Latn, 1,099,244 speakers), Bafut (Latn, 158,146 speakers), Koonzime (Latn, 40,000 speakers), Zapotec (Latn, 490,000 speakers), Ma’di (Latn, 584,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
Review@bghryct, done :) Emma's tasks
Upstream's tasks
|
Working on this @emmamarichal |
Closing this one too, same reason as Tac (missing "One") |
0ab3871: [gftools-packager] Madimi: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added