Gftools packager ofl kodemono

[isaozler]

No description provided.

[emmamarichal]

Hello @isaozler, thank you for that PR!
I noticed some interpolation issues here:

Also, the url for the OFL license changed recently, it's now https://openfontlicense.org/ instead of https://scripts.sil.org/OFL
It needs to be changed in the OFL.txt and in the font infos (License + License URL)

Thank you :)

[emmamarichal]

@isaozler If you could update your repo, it would be great! You can read this: https://googlefonts.github.io/gf-guide/upstream.html

[isaozler]

Hi @emmamarichal, fixed the issues and updated the repo 👍

[emmamarichal]

Hi @isaozler! Thanks a lot :)

Sorry, I noticed some other small issues to fix, after that, it should be good :)

• In font info:
  • LicenseURL = https://openfontlicense.org instead of https://scripts.sil.org/OFL
  • License = This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://openfontlicense.org (URL is modified too)
• The slash in lslash, should be rotated a bit, the glyphs seems too dark otherwise.
• Problem with ogonek
• Small figures looks very light compare to the base letters. Should be a little darker. (for this point, it's more an advice than a request)

I just have two fails lefts.
@m4rc1e, I think these fails appeared when we added the classification to metadatas (but maybe I'm wrong)
But classification should work, I think I already made some PRs with it 🤔

☠ FATAL: Check METADATA.pb parse correctly. (com.google.fonts/check/metadata/parses)

* ☠ **FATAL** Family metadata at . failed to parse. TRACEBACK: 28:1 : Message type "google.fonts_public.FamilyProto" has no field named "classification". [code: parsing-error]

🔥 FAIL: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

• 🔥 FAIL Could not parse metadata.pb file [code: unparsable-metadata]

[emmamarichal]

@isaozler I'll add your designer profile to the catalog :) Also, if you have some nice images for promotion on social media, feel free to send them to me by email! Thanks!

[isaozler]

Hi @emmamarichal, thanks for your reply. I updated/fixed the issues mentioned. The last point/advice was something that was bothering me too. So, what I did to fix that for now is to use the bold variant for all instances. I am afraid that going bolder on the bold one will not work great. I will update the number glyphs in the next iteration to be specific for the inferior and superior. But for now, we can stick to using this variant.

[isaozler]

I'm looking forward to your review 👍 I'll reach out to you concerning the promotional material for social media. Thanks in advance.

[emmamarichal]

Hi @isaozler!
That's much better, thank you :)

I caught last few things, since you will probably correct the 8, I put here some other suggestions for improving:

• Check ogonek alignments
• The commaaccent and hungarumlaut look a bit thin in the regular master
• The eight has a different weight in fractions
• The returned comma accent looks a bit heavy and tall, and too close from the 'g'

[isaozler]

🙏 Great catches 💯 thanks. Fixed the issues and suggestions for improvement.

[emmamarichal]

Excellent @isaozler, thanks a lot!