-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sixtyfour: Version 2.001 added #7025
Conversation
* Sixtyfour Version 2.001 taken from the upstream repo https://github.com/jenskutilek/homecomputer-fonts at commit jenskutilek/homecomputer-fonts@09b2f79.
This comment was marked as outdated.
This comment was marked as outdated.
@RosaWagner This PR updates Sixtyfour, following what was described in #6919-comment |
Kutílek acute fix
Reinstating link to Workbench
FontBakery reportfontbakery version: 0.10.4 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[17] Sixtyfour[BLED,SCAN].ttf🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids) I don't think it is necessary to solve this check but it highlights a small conflict in the display of the style name of the default instance, so just as info:
So Adobe and Windows are both displaying the font (family name + style name) as we expect, but native apps from Mac are not. Which I don't think is the end of the world tbh; no issue were reported with Kablammo so far. A way to solve this would be to have the master origin called "Close" instead of Regular but I have no idea if the API would actually like it. Maybe that is a conversation to have with the eng team next year for future projects without weight axes. |
Thanks for the detailed note. Yes, we'll need to find a final resolution for fonts with only custom axes. Eventually, if following the last option (to which I agree) we'll need to adjust the build & test tools to accept it. |
e0fab0e: [gftools-packager] Sixtyfour: Version 2.001 added