Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji 15.1 #7019

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Emoji 15.1 #7019

merged 1 commit into from
Nov 27, 2023

Conversation

rsheeter
Copy link
Collaborator

Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked. [code: no-glyphset-supported]

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[39] NotoColorEmoji-Regular.ttf
🔥 FAIL: Is this a proper HTML snippet? (com.google.fonts/check/description/valid_html)
  • 🔥 FAIL ofl/notocoloremoji/DESCRIPTION.en_us.html does not include an HTML

    tag. [code: lacks-paragraph]

🔥 FAIL: DESCRIPTION.en_us.html must have more than 200 bytes. (com.google.fonts/check/description/min_length)
  • 🔥 FAIL DESCRIPTION.en_us.html must have size larger than 200 bytes. [code: too-short]
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x00A0 (NO-BREAK SPACE)

    • 0x002E (FULL STOP)

    • 0x003A (COLON)

    • 0x2026 (HORIZONTAL ELLIPSIS)

    • 0x0021 (EXCLAMATION MARK)

    • 0x002F (SOLIDUS)

    • 0x005C (REVERSE SOLIDUS)

    • 0x002D (HYPHEN-MINUS)

    • 0x0028 (LEFT PARENTHESIS)

    • 0x0029 (RIGHT PARENTHESIS)

    • 302 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
  • 🔥 FAIL Please remove the unrecognized subset 'emoji' from the METADATA.pb file. [code: unknown-subset]
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright 2021 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • 🔥 FAIL License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1. This Font Software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong]
🔥 FAIL: Ensure files are not too large. (com.google.fonts/check/file_size)
  • 🔥 FAIL Font file is 22.9Mb, larger than limit 9.0Mb [code: massive-font]
🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • 🔥 FAIL Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/ [code: lacks-gasp]
🔥 FAIL: METADATA.pb should contain at least "menu" and "latin" subsets. (com.google.fonts/check/metadata/menu_and_latin)
  • 🔥 FAIL Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin". [code: missing]
🔥 FAIL: METADATA.pb subsets should be alphabetically ordered. (com.google.fonts/check/metadata/subsets_order)
  • 🔥 FAIL METADATA.pb subsets are not sorted in alphabetical order: Got ['menu', 'emoji'] and expected ['emoji', 'menu'] [code: not-sorted]
🔥 FAIL: METADATA.pb font.filename and font.post_script_name fields have equivalent values? (com.google.fonts/check/metadata/match_filename_postscript)
  • 🔥 FAIL METADATA.pb font filename = "NotoColorEmoji-Regular.ttf" does not match post_script_name="NotoColorEmoji". [code: mismatch]
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "copyright 2021 google inc. all rights reserved." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright 2022 Google Inc." [code: bad-notice-format]
🔥 FAIL: METADATA.pb weight matches postScriptName for static fonts. (com.google.fonts/check/metadata/match_weight_postscript)
  • 🔥 FAIL METADATA.pb: Mismatch between postScriptName ("NotoColorEmoji") and weight value (400). The name must be ended with "Regular" or "Italic".
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
  • 🔥 FAIL Please add a family.source.repository_url entry. [code: lacks-repo-url]
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
  • 🔥 FAIL Font names are incorrect:
nameID current expected
Family Name Noto Color Emoji Noto Color Emoji
Subfamily Name Regular Regular
Full Name Noto Color Emoji Noto Color Emoji Regular
Postscript Name NotoColorEmoji NotoColorEmoji-Regular
  • WARN Regular missing from full name [code: lacks-regular]
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ? (com.google.fonts/check/metadata/nameid/copyright)
  • 🔥 FAIL Copyright field for this font on METADATA.pb ("Copyright 2021 Google Inc. All Rights Reserved.") differs from a copyright notice entry on the name table: "Copyright 2022 Google Inc." [code: mismatch]
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
  • 🔥 FAIL The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script. [code: lacks-smart-dropout]
🔥 FAIL: Check font can render its own name. (com.google.fonts/check/render_own_name)
  • 🔥 FAIL .notdef glyphs were found when attempting to render Noto Color Emoji [code: render-own-name]
🔥 FAIL: Noto fonts must have an ARTICLE.en_us.html file (com.google.fonts/check/description/noto_has_article)
  • 🔥 FAIL This is a Noto font but it lacks an ARTICLE.en_us.html file [code: missing-article]
🔥 FAIL: Font contains glyphs for whitespace characters? (com.google.fonts/check/whitespace_glyphs)
  • 🔥 FAIL Whitespace glyph missing for codepoint 0x00A0. [code: missing-whitespace-glyph-0x00A0]
🔥 FAIL: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • 🔥 FAIL The following glyphs have no contours even though they were expected to have some:

    • Glyph name: numbersign Expected: 2

    • Glyph name: asterisk Expected: 1 or 4

    • Glyph name: zero Expected: 2 or 3

    • Glyph name: one Expected: 1

    • Glyph name: two Expected: 1

    • Glyph name: three Expected: 1

    • Glyph name: four Expected: 1 or 2

    • Glyph name: five Expected: 1

    • Glyph name: six Expected: 1 or 2

    • Glyph name: seven Expected: 1

    • 44 more.

Use -F or --full-lists to disable shortening of long lists.
[code: no-contour]

🔥 FAIL: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+200D ZERO WIDTH JOINER: try adding one of: batak, tamil, tirhuta, kayah-li, syriac, buginese, mongolian, balinese, chakma, phags-pa, sharada, meetei-mayek, old-hungarian, kharoshthi, dogra, khudawadi, psalter-pahlavi, saurashtra, manichaean, syloti-nagri, thaana, tibetan, grantha, newa, javanese, new-tai-lue, pahawh-hmong, limbu, brahmi, lepcha, nko, warang-citi, tai-le, gurmukhi, devanagari, khojki, myanmar, tagalog, tai-tham, telugu, thai, tai-viet, siddham, sundanese, gunjala-gondi, malayalam, buhid, kaithi, kannada, duployan, cham, mahajani, rejang, avestan, bengali, sinhala, tagbanwa, yi, oriya, modi, gujarati, takri, mandaic, hanunoo, tifinagh, hanifi-rohingya

  • U+203C DOUBLE EXCLAMATION MARK: not included in any glyphset definition

  • U+2049 EXCLAMATION QUESTION MARK: try adding mongolian

  • U+20E3 COMBINING ENCLOSING KEYCAP: try adding symbols

  • U+2139 INFORMATION SOURCE: not included in any glyphset definition

  • U+2194 LEFT RIGHT ARROW: try adding one of: math, symbols

  • U+2195 UP DOWN ARROW: try adding one of: math, symbols

  • U+2196 NORTH WEST ARROW: try adding one of: math, symbols

  • U+2197 NORTH EAST ARROW: try adding one of: math, symbols

  • U+2198 SOUTH EAST ARROW: try adding one of: math, symbols
    1459 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu, emoji [code: unreachable-subsetting]

WARN: METADATA.pb: Check for primary_script (com.google.fonts/check/metadata/primary_script)
  • WARN METADATA.pb: primary_script field should be 'Hani' but is missing.
    Make sure that 'Hani' is actually the correct one (out of Jpan, Hani, Hant, Hans). [code: missing-primary-script]
WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
  • WARN Following glyphs differ greatly from Google Fonts version:
    • glyph03850
    • glyph03851
    • glyph03852
    • glyph03853
    • glyph03854
    • glyph03855
    • glyph03856
    • glyph03857
    • glyph03858
    • glyph03860 and 17072 more.

Use -F or --full-lists to disable shortening of long lists.

WARN: Does the font contain less than 150 CJK characters? (com.google.fonts/check/cjk_not_enough_glyphs)
  • WARN There are only 2 CJK glyphs when there needs to be at least 150 in order to support the smallest CJK writing system, Kana.
    The following CJK glyphs were found:
    ['uni3297', 'uni3299']
    Please check that these glyphs have the correct unicodes. [code: cjk-not-enough-glyphs]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value (com.google.fonts/check/gpos_kerning_info)
  • WARN GPOS table lacks kerning information. [code: lacks-kern-info]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notocoloremoji/NotoColorEmoji-Regular.ttf
Dehinted Size 22.9Mb
Hinted Size 22.9Mb
Increase -24 bytes
Change -0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.041;GOOG;noto-emoji:20231120:69db1642752d1457ed8cfa6880781a9f36c9722e'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.041;GOOG;noto-emoji:20231120:69db1642752d1457ed8cfa6880781a9f36c9722e"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • GSUB

    • vhea

    • vmtx [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notocoloremoji [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 25 9 76 7 138 0
0% 10% 4% 30% 3% 54% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@rsheeter rsheeter merged commit fac8b83 into main Nov 27, 2023
9 checks passed
@rsheeter rsheeter deleted the e151 branch November 27, 2023 22:33
@jbicha
Copy link

jbicha commented Nov 28, 2023

@rsheeter Could you update DESCRIPTION.en_US.html ? It mentions Unicode 14.0 and probably has an out-of-date emoji count too.

@eliheuer
Copy link
Collaborator

eliheuer commented Dec 5, 2023

We are tracking onboarding of this from this PR: #7039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants