Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubik Doodle Shadow: Version 2.201 added #6999

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

RosaWagner
Copy link
Contributor

@RosaWagner RosaWagner commented Nov 22, 2023

981d8c3: [gftools-packager] Rubik Doodle Shadow: Version 2.201 added

Closes #3710

For fails to ignore see #6998

This comment was marked as outdated.

@emmamarichal
Copy link
Collaborator

Maybe to confirm with the designer if these kind of things ok
-> avoid the overlapping(1) with a small dot? (2)

(1)
Capture d’écran 2023-11-22 à 17 55 46

(2)
Capture d’écran 2023-11-22 à 17 56 44

@RosaWagner
Copy link
Contributor Author

Yes ideally it would better to avoid that.

@RosaWagner RosaWagner added the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 23, 2023
@RosaWagner
Copy link
Contributor Author

Updated

Rubik Doodle Shadow: Version 2.201 added


0a22934: [gftools-packager] Rubik Doodle Shadow: Version 2.201 added

@RosaWagner RosaWagner force-pushed the gftools_packager_ofl_rubikdoodleshadow branch from 981d8c3 to 0a22934 Compare November 23, 2023 12:42
@RosaWagner RosaWagner removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 23, 2023
@RosaWagner
Copy link
Contributor Author

@emmamarichal just fixed it

Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
haw_Latn (Hawaiian) Some base glyphs were missing: ʻ
^ Shaper produced a .notdef
mh_Latn (Marshallese) Some base glyphs were missing: Ḷ, ḷ, Ṃ, ṃ, Ṇ, ṇ, Ọ, ọ
^ Some mark glyphs were missing: ◌̣
^ Shaper produced a .notdef
scn_Latn (Sicilian) Some base glyphs were missing: Ḍ, ḍ
^ Shaper produced a .notdef
teo_Latn (Teso) Some base glyphs were missing: Ɔ, Ɛ, Ɨ, Ʉ, ɔ, ɛ, ɨ, ʉ, ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᵘ, ᶤ, ᶶ, ⁱ
^ Shaper produced a .notdef

[code: failed-language-shaping]

  • 🔥 FAIL GF_Cyrillic_Plus glyphset:
Language FAIL messages
tg_Cyrl (Tajik) Some base glyphs were missing: ҳ
^ Shaper produced a .notdef
uz_Cyrl (Uzbek (Cyrillic)) Some base glyphs were missing: ҳ
^ Shaper produced a .notdef

[code: failed-language-shaping]

  • WARN GF_Latin_Core glyphset:
Language FAIL messages
lg_Latn (Ganda) No variant glyphs were found for Eng
dyo_Latn (Jola-Fonyi) No variant glyphs were found for Eng
ny_Latn (Nyanja) No variant glyphs were found for Eng
wo_Latn (Wolof) No variant glyphs were found for Eng

[code: warning-language-shaping]

  • WARN GF_Cyrillic_Plus glyphset:
Language FAIL messages
ku_Cyrl (Kurdish) No exemplar glyphs were defined for language Kurdish

[code: warning-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] RubikDoodleShadow-Regular.ttf
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)

But: OFL text has 'https:/' and HTML description has 'github.com/NaN-xyz/Glyph-Filters'
[code: mismatch]

🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1185 when it should be at least 1200 [code: bad-hhea-range]
🔥 FAIL: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • 🔥 FAIL Designer Luke Prowse still does not have an avatar image. Please provide one. [code: missing-avatar]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition
    37 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, hebrew, latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Ensure files are not too large. (com.google.fonts/check/file_size)
  • WARN Font file is 1.3Mb; ideally it should be less than 1.0Mb [code: large-font]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • i + l [code: lacks-kern-info]

WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 4	Expected: 2

- Glyph name: quotedbl	Contours detected: 14	Expected: 2

- Glyph name: numbersign	Contours detected: 15	Expected: 2

- Glyph name: dollar	Contours detected: 13	Expected: 1, 3 or 5

- Glyph name: percent	Contours detected: 35	Expected: 5

- Glyph name: ampersand	Contours detected: 14	Expected: 1, 2 or 3

- Glyph name: quotesingle	Contours detected: 2	Expected: 1

- Glyph name: parenleft	Contours detected: 2	Expected: 1

- Glyph name: parenright	Contours detected: 3	Expected: 1

- Glyph name: asterisk	Contours detected: 10	Expected: 1 or 4

- 1170 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 538 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 594:
plus

Width = 563:
equal

Width = 564:
logicalnot

Width = 576:
plusminus

Width = 639:
multiply

Width = 517:
divide

Width = 642:
minus

Width = 551:
approxequal, notequal

Width = 556:
lessequal, greaterequal
[code: width-outliers]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • A (U+0041): B<<31.0,-15.0>-<31.0,-14.0>-<36.0,-13.0>>/B<<36.0,-13.0>-<32.0,-13.0>-<28.0,-13.0>> = 11.309932474020195

    • A (U+0041): B<<35.0,183.0>-<35.0,184.0>-<36.0,184.0>>/L<<36.0,184.0>--<30.0,183.0>> = 9.462322208025613

    • A (U+0041): B<<754.0,47.5>-<758.0,47.0>-<762.0,45.0>>/B<<762.0,45.0>-<759.0,47.0>-<757.0,48.0>> = 7.125016348901757

    • A (U+0041): L<<139.0,-21.0>--<146.0,-18.0>>/L<<146.0,-18.0>--<140.0,-20.0>> = 4.76364169072622

    • A (U+0041): L<<373.0,76.0>--<364.0,72.0>>/L<<364.0,72.0>--<377.0,76.0>> = 6.859760005525852

    • A (U+0041): L<<457.0,69.0>--<472.0,75.0>>/B<<472.0,75.0>-<470.0,74.0>-<467.0,74.0>> = 4.763641690726143

    • A (U+0041): L<<91.0,-16.0>--<99.0,-14.0>>/B<<99.0,-14.0>-<98.0,-14.0>-<97.0,-14.0>> = 14.036243467926484

    • A (U+0041): L<<97.0,-14.0>--<91.0,-16.0>>/L<<91.0,-16.0>--<99.0,-14.0>> = 4.398705354995591

    • AE (U+00C6): B<<14.0,-28.0>-<12.0,-24.0>-<16.0,-22.0>>/L<<16.0,-22.0>--<3.0,-26.0>> = 9.462322208025574

    • AE (U+00C6): B<<559.0,-15.0>-<560.0,-15.0>-<564.0,-14.0>>/B<<564.0,-14.0>-<561.0,-14.0>-<555.0,-15.0>> = 14.036243467926484

    • 3083 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ і́

The dot of soft dotted characters should disappear in other cases, for example: i̦̒ j̦̒ į̆ į̇ į̈ į̊ į̋ į̒ į̦̒ į̧̒ į̨̒ į̵̀ į̵́ į̵̂ į̵̃ į̵̄ į̵̆ į̵̇ į̵̈ į̵̊

Your font fully covers the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers), Ukrainian (Cyrl, 29,273,587 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Navajo (Latn, 166,319 speakers), Nateni (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Igbo (Latn, 27,823,640 speakers), Ebira (Latn, 2,200,000 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), Gulay (Latn, 250,478 speakers), Sar (Latn, 500,000 speakers), Ma’di (Latn, 584,000 speakers), Kom (Latn, 360,685 speakers), Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/rubikdoodleshadow/RubikDoodleShadow-Regular.ttf
Dehinted Size 1.3Mb
Hinted Size 1.3Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.201'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.201"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/rubikdoodleshadow [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 10 66 9 166 0
0% 2% 4% 26% 4% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit 35cdae2 into main Nov 23, 2023
9 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_rubikdoodleshadow branch November 23, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Rubik Doodle Shadow
2 participants