Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add font tagging data #6966

Merged
merged 1 commit into from
Nov 16, 2023
Merged

add font tagging data #6966

merged 1 commit into from
Nov 16, 2023

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Nov 15, 2023

Updates #6955

@nyshadhr9 nyshadhr9 self-requested a review November 16, 2023 01:22
nyshadhr9
nyshadhr9 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@nyshadhr9 nyshadhr9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rsheeter
Copy link
Collaborator

We've started to use this so lets land and iterate.

@m4rc1e m4rc1e merged commit 239ed4f into main Nov 16, 2023
9 checks passed
@m4rc1e m4rc1e deleted the font-tags branch November 16, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyshadhr9 nyshadhr9 nyshadhr9 approved these changes

Assignees
No one assigned
Labels
I Tools / workflow / repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4rc1e @rsheeter @nyshadhr9 @RosaWagner