-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruslandisplay/METADATA & DESC for proper attribution #6946
Conversation
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[42] RuslanDisplay.ttf🔥 FAIL: Checking file is named canonically. (com.google.fonts/check/canonical_filename)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"copyright (c) 2010, 2011, denis masharov [email protected]," which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: METADATA.pb subsets should be alphabetically ordered. (com.google.fonts/check/metadata/subsets_order)
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
🔥 FAIL: METADATA.pb weight matches postScriptName for static fonts. (com.google.fonts/check/metadata/match_weight_postscript)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
🔥 FAIL: Check font names are correct (com.google.fonts/check/font_names)
🔥 FAIL: Directory name in GFonts repo structure must match NameID 1 of the regular. (com.google.fonts/check/repo/dirname_matches_nameid_1)
🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)
🔥 FAIL: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
🔥 FAIL: Are there unwanted tables? (com.google.fonts/check/unwanted_tables)
They can be removed with the 'fix-unwanted-tables' script provided by gftools. [code: unwanted-tables] 🔥 FAIL: Space and non-breaking space have the same width? (com.google.fonts/check/whitespace_widths)
🔥 FAIL: Description strings in the name table must not contain copyright info. (com.google.fonts/check/name/no_copyright_on_description)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Description strings in the name table must not exceed 200 characters. (com.google.fonts/check/name/description_max_length)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Ensure fonts do not contain any pre-production tables. (com.google.fonts/check/no_debugging_tables)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 272: Width = 287: Width = 615: Width = 284: Width = 319: Width = 358: Width = 377: ⚠ WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
⚠ WARN: Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value (com.google.fonts/check/gpos_kerning_info)
⚠ WARN: Check for points out of bounds. (com.google.fonts/check/points_out_of_bounds)
This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message. [code: points-out-of-bounds] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Is there a usable "kern" table declared in the font? (com.google.fonts/check/kern_table)
Summary
Note: The following loglevels were omitted in this report:
|
These 2 fails must be resolved to be able to be pushed to sandbox: 🔥 FAIL: Checking file is named canonically. (com.google.fonts/check/canonical_filename) 🔥 FAIL: METADATA.pb subsets should be alphabetically ordered. (com.google.fonts/check/metadata/subsets_order) |
These 2 fails can easily be hotfixed: 🔥 FAIL: Description strings in the name table must not contain copyright info. (com.google.fonts/check/name/no_copyright_on_description) 🔥 FAIL: Are there unwanted tables? (com.google.fonts/check/unwanted_tables) FFTM - Table contains redundant FontForge timestamp info They can be removed with the 'fix-unwanted-tables' script provided by gftools. [code: unwanted-tables] |
Since the file isn't changing, and it is important to correct the attribution, I am kindly declining to change the font files as a blocker on pushing these changes; its good for @yanone to fix the font, but it must not block these changes. |
Maybe then it would be desirable to hotfix the font so that the metadata of the font file matches what will be said in METADATA & DESC? |
I don't want to wait. |
The eng team won’t be able to push if we don’t fix these 2 metadata issue, it literally will block the push. It takes 2 minutes to add « Regular » to the file name, and 2 more to put the subsets in the alphabetical order. The font would be on the list already if you had asked for a review before merging. |
I'm confused; the changes are already on sandbox, and look good, so I've added to |
Then I am confused because these kind of issues already blocked a push in the past, requiring the eng team to fix it to be able to continue. |
Fixes #6740