Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Gujarati: Version 2.106 added #6778

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

simoncozens
Copy link
Collaborator

dcbe8bc: [gftools-packager] Noto Sans Gujarati: Version 2.105 added

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-wdth', 1) [code: summary]


[14] NotoSansGujarati[wdth,wght].ttf
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, tifinagh, canadian-aboriginal, math, old-permic, malayalam, syriac, tai-le

  • U+030A COMBINING RING ABOVE: try adding syriac
    9 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: gujarati, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • charanuktaprehalfUIgujr

    • charaprehalfUIgujr

    • daraprehalfUIgujr

    • ddaranuktaprehalfUIgujr

    • ddaraprehalfUIgujr

    • ddharanuktaprehalfUIgujr

    • ddharaprehalfUIgujr

    • llvocalicvowelsignlowgujr

    • lvocalicvowelsignlowgujr

    • ngaranuktaprehalfUIgujr

    • 21 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'uuvowelsignnuktagujr' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f027de9ee30> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f027de2bd60> [code: interpolation-issues]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Aghem (Latn, 38,843 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosansgujarati/NotoSansGujarati[wdth,wght].ttf
Dehinted Size 657.1kb
Hinted Size 657.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.105'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.105"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosansgujarati [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 7 42 8 192 0
0% 0% 3% 17% 3% 77% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

This release:

* Fixes the position of nukta below other marks (#28)
* Reorders the sequence U+0AFD, U+0AFC (#30)
* Improves the display of the sequence U+0AFF U+0AFA (#31)
* Improves the positioning of ligated marks with repha or anusvara (#33)

@simoncozens simoncozens mentioned this pull request Oct 4, 2023
41 tasks
@emmamarichal
Copy link
Collaborator

Hi @simoncozens,
It's the first time I review a Noto font, so maybe don't take everything I've found into account. I'm not sure how important this is or isn't, let me know!


  • Some glyphs are not displayed anymore:
Enregistrement.de.l.ecran.2023-10-26.a.10.27.33.mov
  • I know that the position of this accent is part of the update, but is it normal that it is no longer centered on the circledot?
Enregistrement.de.l.ecran.2023-10-26.a.10.29.20.mov
  • There is a interpolation issue on uuvowelsignnuktagujr's dot
Capture d’écran 2023-10-26 à 10 22 35

@simoncozens
Copy link
Collaborator Author

Some glyphs are not displayed anymore:

IJ was removed from the Google Fonts Latin Core set, this is expected. Danda and double danda... oops, they should be there. Good catch.

it is no longer centered on the circledot

My interpretation of dotted circles is that they are meant to show a representative example of where the mark will be positioned on a glyph. i.e. the dotted circle stands for "any glyph" and the mark is shown where it would appear. The nukta is usually positioned on the stem, which is on the right of the glyph, so this is fine.

There is a interpolation issue on uuvowelsignnuktagujr's dot

Nice. I will fix that and the danda, and re-release.

@RosaWagner RosaWagner added the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 26, 2023
@simoncozens
Copy link
Collaborator Author

Updated

Noto Sans Gujarati: Version 2.106 added


922dd2d: [gftools-packager] Noto Sans Gujarati: Version 2.106 added

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notosansgujarati branch from dcbe8bc to 922dd2d Compare October 26, 2023 10:11
@github-actions
Copy link

FontBakery report

fontbakery version: 0.10.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght-wdth', 1) [code: summary]


[13] NotoSansGujarati[wdth,wght].ttf
🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
  • 🔥 FAIL Glyph "Aacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Abreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Acircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Adieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Agrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Aogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Aring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Atilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Cacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ccaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ccedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Cdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Dcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Eacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ecaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ecircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Edieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Edotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Egrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Eogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Gbreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Gdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Iacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Icircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Idieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Idotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Igrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Iogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Lacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Nacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ncaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ntilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Oacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ocircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Odieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ograve" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ohungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Otilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Racute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Rcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Sacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Scaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Scedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Tcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Uacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ubreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ucircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Udieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ugrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Uhungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Uring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Wacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Wcircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Wdieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Wgrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Yacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ycircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ydieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Ygrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Zacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Zcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "Zdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "aacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "abreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "acircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "acutecomb" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "adieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "agrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "aogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "aring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "atilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0306" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "cacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni030C" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ccaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ccedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "cdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0327" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0302" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0308" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0307" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "eacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ecaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ecircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "edieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "edotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "egrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "gbreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "gdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "gravecomb" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni030B" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "iacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "icircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "idieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "igrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "iogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "lacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "nacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ncaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ntilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "oacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ocircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "odieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni0328" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ograve" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ohungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "otilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "racute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "rcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uni030A" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "sacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "scaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "scedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "tildecomb" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ubreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ucircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "udieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ugrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uhungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "uring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "wacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "wcircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "wdieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "wgrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "yacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ycircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ydieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "ygrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "zacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "zcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • 🔥 FAIL Glyph "zdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    7 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: gujarati, latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • charanuktaprehalfUIgujr

    • charaprehalfUIgujr

    • daraprehalfUIgujr

    • ddaranuktaprehalfUIgujr

    • ddaraprehalfUIgujr

    • ddharanuktaprehalfUIgujr

    • ddharaprehalfUIgujr

    • llvocalicvowelsignlowgujr

    • lvocalicvowelsignlowgujr

    • ngaranuktaprehalfUIgujr

    • 21 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Basaa (Latn, 332,940 speakers), Koonzime (Latn, 40,000 speakers), Ebira (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ma’di (Latn, 584,000 speakers), Ejagham (Latn, 120,000 speakers), Nateni (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosansgujarati/NotoSansGujarati[wdth,wght].ttf
Dehinted Size 657.1kb
Hinted Size 657.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.106'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.106"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosansgujarati [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 5 43 8 197 0
0% 0% 2% 17% 3% 78% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

Check that legacy accents aren't used in composite glyphs

Oh jeepers what now? This is going to affect all Noto until Noto Sans/Serif are "fixed". Does it really matter whether a spacing or a non-spacing accent glyph is used to make a composite?

@RosaWagner
Copy link
Contributor

Oh jeepers what now? This is going to affect all Noto until Noto Sans/Serif are "fixed". Does it really matter whether a spacing or a non-spacing accent glyph is used to make a composite?

It does, yes. It is the only way we can insure the subsetter would display the same accented letter wether it calls it by the codepoint or by combining the base letter and the accent.

I would obviously ignore the fail though for the Noto collection because, as you said, Noto Sans/Serif need to be fixed first and the fonts are already onboarded like that, so let's just move on and this will be for the next wave of upgrades. Tip: if the composites seem okay in the source, it means this is caused by the un-nesting of components.

@RosaWagner RosaWagner removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 26, 2023
@RosaWagner RosaWagner merged commit e79a207 into main Oct 27, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notosansgujarati branch October 27, 2023 10:49
@eliheuer eliheuer changed the title Noto Sans Gujarati: Version 2.105 added Noto Sans Gujarati: Version 2.106 added Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

3 participants