Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Khojki: Version 2.005 added #6774

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

simoncozens
Copy link
Collaborator

96deac9: [gftools-packager] Noto Serif Khojki: Version 2.005 added

@simoncozens
Copy link
Collaborator Author

Noto Serif Khojki v2.005

This release:

* Improves the display of nukta combinations (#14, #22)
* Correct reorders the nukta + sukun combination (#15)
* Allow conjuncts to form in the presence of a nukta (#16)
* Uses the steeper alternative E vowel to avoid clashes (#17)
* Fixes the kerning and display of AI vowel (#18)
* Removes some unnecessary glyphs (#19)
* Adds the newly encoded characters QA (U+1123F) and SHORT I (U+11240)

@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[19] NotoSerifKhojki[wght].ttf
🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 🔥 FAIL Font can't render "sd_Khoj" sample text:
    "𑈩𑈤𑈨𑈦𑈬𑈺𑈀𑈞𑈩𑈬𑈞𑈺𑈁𑈐𑈶𑈬𑈛𑈺𑈂𑈺𑈀𑈐𑈶𑈙𑈺𑈂𑈺𑈪𑈈𑈶𑈞𑈺ڄ𑈥𑈺𑈪𑈨𑈬𑈧𑈥𑈺ڪ𑈀𑈞𑈺𑈞𑈦𑈬𑈞𑈦𑈺𑈟𑈥𑈛𑈬ٿ𑈥𑈬𑈺𑈁𑈪𑈞𑈸𑈺𑈀𑈞𑈪𑈞"
    [code: sample-text]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, cherokee, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: math, old-permic, tai-le, tifinagh, canadian-aboriginal, syriac, malayalam, coptic

  • U+030A COMBINING RING ABOVE: try adding syriac
    10 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: khojki, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NullMark

    • dblsectionmark.alt

    • sha_eMatrakhoj

    • sha_iMatrakhoj

    • sha_iiMatrakhoj

    • sha_uMatrakhoj

    • shakhoj

    • sixkhoj.alt
      [code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'dda_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 0 start point differs in glyph 'nn_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 0 start point differs in glyph 'dd_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 1 start point differs in glyph 'nn_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 1 start point differs in glyph 'dd_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 1 start point differs in glyph 'nn_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 1 start point differs in glyph 'dd_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0>

    • Contour 1 start point differs in glyph 'nna_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f78524886a0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f785248ada0> [code: interpolation-issues]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 558:
multiply, plus
[code: width-outliers]

WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+11235 [code: non-mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • parenleft (U+0028): X=284.0,Y=715.0 (should be at cap-height 714?)

    • parenright (U+0029): X=117.0,Y=715.0 (should be at cap-height 714?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • a (U+0061): X=182.0,Y=536.5 (should be at x-height 536?)

    • c (U+0063): X=360.0,Y=535.0 (should be at x-height 536?)

    • f (U+0066): X=331.0,Y=712.5 (should be at cap-height 714?)

    • g (U+0067): X=161.0,Y=-0.5 (should be at baseline 0?)

    • h (U+0068): X=66.5,Y=713.5 (should be at cap-height 714?)

    • 45 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Basaa (Latn, 332,940 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Ukrainian (Cyrl, 29,273,587 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifkhojki/NotoSerifKhojki[wght].ttf
Dehinted Size 227.6kb
Hinted Size 227.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.005'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.005"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifkhojki [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 11 45 8 184 0
0% 0% 4% 18% 3% 74% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens mentioned this pull request Oct 4, 2023
41 tasks
@m4rc1e m4rc1e merged commit 4e2d48d into main Oct 25, 2023
@m4rc1e m4rc1e deleted the gftools_packager_ofl_notoserifkhojki branch October 25, 2023 11:53
@RosaWagner RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Nov 16, 2023
@RosaWagner RosaWagner mentioned this pull request Nov 16, 2023
@eliheuer
Copy link
Collaborator

eliheuer commented Dec 5, 2023

@simoncozens Noto Serif Khojki still has tofu in sandbox despite #6970 also being in sandbox.

Screenshot 2023-12-05 at 11 11 23 AM

@simoncozens
Copy link
Collaborator Author

My fault, I missed a character when fixing up the sample texts.

@simoncozens
Copy link
Collaborator Author

Filed googlefonts/lang#135 to fix.

@simoncozens simoncozens removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Jan 22, 2024
@simoncozens
Copy link
Collaborator Author

This should be good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

4 participants