Moe sync #740
Merged
Moe sync #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #711 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=166083196
This enables tools like the Gradle License Plugin (https://github.com/jaredsburrows/gradle-license-plugin) to work Fixes #721 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167276031
This is a simplified subset of NamedParameterChecker. Only handling the recommended comment style means associating comments with arguments is more precise, simpler, and faster, so this could potentially be enabled as an error. RELNOTES: Add a check to ensure /* name= */-style parameter comments match the corresponding formal parameter name ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167308354
… field of @BugPattern annotation. RELNOTES: Create ProvidesFixChecker ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167340492
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167388444
Allow long non-file arguments (e.g. -classpath) to go to a file. This prevents E2BIG when the classpath argument is too long. This can't easily be fixed in upstream ant because: (a) it would require an API change, and (b) there is no way for ant to know which arguments are safe to spill Fixes #671 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=167726515
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@cushon can you submit if everything is OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.