Extend ProtoStringFieldReferenceEquality to support older versions of protobuf #5260
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styurin
force-pushed
the
st/proto-string-message
branch
from
4a355d1 to
7733b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtoStringFieldReferenceEqualityassumes that all protobuf messages extendcom.google.protobuf.GeneratedMessage, but older versions of protobuf (before v26) usecom.google.protobuf.GeneratedMessageV3as the base class for messages.This change updates
ProtoStringFieldReferenceEqualityto usecom.google.protobuf.MessageLiteto detect protobufs. This interface is present in older versions of protobuf and it hasn't changed since then.