Wrap Option in Result rather than vice-versa for find_node.#12
Merged
Conversation
qwandor
force-pushed
the
optionresult
branch
2 times, most recently
from
d70bdaf to
fbae3b8
Compare
m4tx
approved these changes
Dec 15, 2025
qwandor
force-pushed
the
nameaddress
branch
2 times, most recently
from
5dc0e64 to
8ef23af
Compare
qwandor
force-pushed
the
optionresult
branch
from
fbae3b8 to
f0b1dcf
Compare
This makes more sense logically, and makes error handling easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes more sense logically, and makes error handling easier.