"Token Types" chapter of Idiomatic Rust #2921

tall-vase · 2025-09-22T09:30:37Z

Materials on "token types."

The "Branded tokens" section of this one requires a little extra scrutiny. It may be the case it is too complex for this stage, or that the explanation isn't suitable for the audience/instructors. Either way, I'm eager for input.

google-cla · 2025-09-22T09:30:42Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

The previous STYLE.md advised against using speaker notes as a 'script' but didn't provide clear examples of what that meant. This could be interpreted by LLMs as disallowing any kind of instructor prompt. This change clarifies the guideline by: 1. Distinguishing between long-form, verbatim 'scripts' (bad) and short, actionable 'teaching prompts' (good). 2. Providing concrete 'good' and 'bad' examples to make the distinction unambiguous for future contributors.

src/idiomatic/leveraging-the-type-system/token-types.md

…all-vase/comprehensive-rust into idiomatic/typesystem-tokens

STYLE.md

src/idiomatic/leveraging-the-type-system/token-types.md

src/idiomatic/leveraging-the-type-system/token-types/mutex-guard.md

src/idiomatic/leveraging-the-type-system/token-types/branded-tokens.md

src/idiomatic/leveraging-the-type-system/token-types.md

src/idiomatic/leveraging-the-type-system/token-types/branded-tokens.md

Co-authored-by: Dmitri Gribenko <[email protected]>

src/idiomatic/leveraging-the-type-system/token-types/permission-tokens.md

src/idiomatic/leveraging-the-type-system/token-types.md

src/idiomatic/leveraging-the-type-system/token-types/mutex-guard.md

src/idiomatic/leveraging-the-type-system/token-types/branded-03-impl.md

src/idiomatic/leveraging-the-type-system/token-types/branded-tokens.md

src/idiomatic/leveraging-the-type-system/token-types/branded-01-motivation.md

src/idiomatic/leveraging-the-type-system/token-types/branded-03-impl.md

src/idiomatic/leveraging-the-type-system/token-types/permission-tokens.md

Co-authored-by: Dmitri Gribenko <[email protected]>

Still needs a pass on flow

src/idiomatic/leveraging-the-type-system/token-types/branded-01-motivation.md

src/idiomatic/leveraging-the-type-system/token-types.md

src/idiomatic/leveraging-the-type-system/token-types/branded-03-impl.md

Co-authored-by: Dmitri Gribenko <[email protected]>

…urning directly in the branded implementation

src/idiomatic/leveraging-the-type-system/token-types/branded-02-phantomdata.md

src/idiomatic/leveraging-the-type-system/token-types/branded-03-impl.md

src/idiomatic/leveraging-the-type-system/token-types/branded-01-motivation.md

Co-authored-by: Dmitri Gribenko <[email protected]>

tall-vase added 3 commits September 11, 2025 08:08

Initial skeleton for token types

b7e8128

Reframe around mutexguard and a gentle walkthrough of branded tokens

1a7d356

Another editing pass, focused on the branded tokens slide

d7f3984

tall-vase added the deep_dives/idiomatic label Sep 22, 2025

gribozavr and others added 6 commits September 22, 2025 11:44

Formatting pass

ba2ceda

Initial skeleton for token types

400c336

Reframe around mutexguard and a gentle walkthrough of branded tokens

a70aa6b

Another editing pass, focused on the branded tokens slide

29872e3

Formatting pass

bc6abb0

mgeisler reviewed Sep 22, 2025

View reviewed changes

src/idiomatic/leveraging-the-type-system/token-types.md Show resolved Hide resolved

tall-vase added 4 commits September 22, 2025 19:06

Merge branch 'idiomatic/typesystem-tokens' of github.com-mainmatter:t…

aa3b402

…all-vase/comprehensive-rust into idiomatic/typesystem-tokens

fix merge artefact

d47ca92

fix test errors

a23df16

Address lints

dfebb37

gribozavr self-requested a review September 28, 2025 19:11

gribozavr requested changes Sep 28, 2025

View reviewed changes

gribozavr assigned tall-vase Sep 28, 2025

gribozavr added the waiting for author Waiting on the issue author to reply label Sep 28, 2025

tall-vase and others added 7 commits October 1, 2025 11:29

Update src/idiomatic/leveraging-the-type-system/token-types.md

6c2157d

Co-authored-by: Dmitri Gribenko <[email protected]>

Apply suggestions from review

146a30f

Co-authored-by: Dmitri Gribenko <[email protected]>

Apply feedback to tokens/mutex slide

63e40dc

Rewrite token types speaker notes and correct mutex explanation

1adee3c

Address further feedback

a680dd8

Fix compilation of branded tokens pt 1

36da55f

Editing pass

af6523c

gribozavr requested changes Oct 3, 2025

View reviewed changes

gribozavr reviewed Oct 3, 2025

View reviewed changes

src/idiomatic/leveraging-the-type-system/token-types/permission-tokens.md Outdated Show resolved Hide resolved

Apply suggestions from code review

a7d0d76

Co-authored-by: Dmitri Gribenko <[email protected]>

tall-vase added 4 commits October 8, 2025 07:42

Address less complex feedback

46b6b35

Rewrite the phanomdata & lifetime subtyping slide

c6160b9

Still needs a pass on flow

Expand on Branded material and perform another editing pass

ae5f961

Make the panic line in branded-01 be commented out by default

c3aa869

tall-vase requested a review from gribozavr October 8, 2025 13:59

gribozavr removed the waiting for author Waiting on the issue author to reply label Oct 8, 2025

gribozavr assigned gribozavr and unassigned tall-vase Oct 8, 2025

gribozavr reviewed Oct 8, 2025

View reviewed changes

gribozavr assigned tall-vase and unassigned gribozavr Oct 8, 2025

gribozavr added the waiting for author Waiting on the issue author to reply label Oct 8, 2025

tall-vase and others added 3 commits October 9, 2025 10:45

Apply suggestions from code review

7267b17

Co-authored-by: Dmitri Gribenko <[email protected]>

Address further feedback

638c885

Copy in and edit gribozavr's suggestion of showing the issue with ret…

25b739e

…urning directly in the branded implementation

tall-vase removed the waiting for author Waiting on the issue author to reply label Oct 10, 2025

tall-vase requested a review from gribozavr October 10, 2025 07:52

gribozavr approved these changes Oct 10, 2025

View reviewed changes

gribozavr reviewed Oct 10, 2025

View reviewed changes

src/idiomatic/leveraging-the-type-system/token-types/branded-01-motivation.md Show resolved Hide resolved

tall-vase and others added 3 commits October 10, 2025 14:49

Apply suggestions from code review

15f1d86

Co-authored-by: Dmitri Gribenko <[email protected]>

Update branded-03-impl.md

33391af

Formatting pass

d96c9ba

gribozavr approved these changes Oct 10, 2025

View reviewed changes

tall-vase merged commit 9dcd6f1 into google:main Oct 10, 2025
36 checks passed

"Token Types" chapter of Idiomatic Rust #2921

"Token Types" chapter of Idiomatic Rust #2921

Uh oh!

Conversation

tall-vase commented Sep 22, 2025

Uh oh!

google-cla bot commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants