Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory manager result bug #1941

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix memory manager result bug #1941

wants to merge 8 commits into from
+121 −25

Conversation

EfesX
Copy link
Contributor

@EfesX EfesX commented Feb 26, 2025

Fixes #1939

LebedevRI
LebedevRI reviewed Feb 26, 2025
View reviewed changes
LebedevRI
LebedevRI reviewed Feb 27, 2025
View reviewed changes
@LebedevRI
Copy link
Collaborator

Yep, something like this should work i suppose.

@EfesX
fix test
fbf959d 
...for msvc
@LebedevRI
Copy link
Collaborator

Hm, and the msvc failures seem real, probably need to explicitly cast something in tests from size_t to int64_t.

@LebedevRI
Copy link
Collaborator

Looks like more casts are needed :)

@EfesX
fix test
eaabe46 
add the correct explicitly casts
@LebedevRI
Copy link
Collaborator

Hmm, those msvc failure look weird. I don't think this PR can cause them.

@EfesX
Copy link
Contributor Author

EfesX commented Feb 28, 2025 •
edited
Loading

Hmm, those msvc failure look weird. I don't think this PR can cause them.

I reproduced the failure on my Windows computer. I don’t understand why, but it seems like the failure is caused by my PR.

e1eaa52 may help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LebedevRI LebedevRI LebedevRI left review comments

@dmah42 dmah42 dmah42 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid Pointer Dereference due to std::vector auto-resizing in Memory Manager Result push_back
3 participants
@EfesX @LebedevRI @dmah42